From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH 1/2] drm/radeon/audio: don't set speaker allocation on DCE3.2 Date: Fri, 18 Oct 2013 08:37:07 +0200 Message-ID: <5260D713.8080603@vodafone.de> References: <1382041373-2162-1-git-send-email-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from smtp-03.vodafone.de (mxout.vodafone.de [80.84.1.40]) by gabe.freedesktop.org (Postfix) with ESMTP id A22CDE7317 for ; Thu, 17 Oct 2013 23:37:09 -0700 (PDT) In-Reply-To: <1382041373-2162-1-git-send-email-alexander.deucher@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alex Deucher , dri-devel@lists.freedesktop.org Cc: Alex Deucher List-Id: dri-devel@lists.freedesktop.org Am 17.10.2013 22:22, schrieb Alex Deucher: > It causes hangs on some asics. > > Bug: > https://bugs.freedesktop.org/show_bug.cgi?id=3D70439 > > Signed-off-by: Alex Deucher Both are: Reviewed-by: Christian K=F6nig > --- > drivers/gpu/drm/radeon/r600_hdmi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/= r600_hdmi.c > index 5b72931..06022e3 100644 > --- a/drivers/gpu/drm/radeon/r600_hdmi.c > +++ b/drivers/gpu/drm/radeon/r600_hdmi.c > @@ -309,6 +309,9 @@ static void dce3_2_afmt_write_speaker_allocation(stru= ct drm_encoder *encoder) > u8 *sadb; > int sad_count; > = > + /* XXX: setting this register causes hangs on some asics */ > + return; > + > list_for_each_entry(connector, &encoder->dev->mode_config.connector_li= st, head) { > if (connector->encoder =3D=3D encoder) > radeon_connector =3D to_radeon_connector(connector);