From: Gabor Juhos <juhosg@openwrt.org>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
rt2x00 Users List <users@rt2x00.serialmonkey.com>
Subject: Re: [PATCH 00/21] rt2x00: separate rt2800 PCI and SoC driver
Date: Fri, 18 Oct 2013 09:57:40 +0200 [thread overview]
Message-ID: <5260E9F4.2070204@openwrt.org> (raw)
In-Reply-To: <CAGXE3d_HZZrEspONsjoqGrynGKYN9pisX-jgRZdV760uuVq5cQ@mail.gmail.com>
Hi Helmut,
> On Thu, Oct 17, 2013 at 9:42 AM, Gabor Juhos <juhosg@openwrt.org> wrote:
>> The rt2800pci driver supports both PCI and SoC device. To achieve
>> this, the code uses several ifdef statements which makes the code
>> quite ugly. The patch set introduces a shared module, and moves the
>> SoC driver into a separate module to get rid of the mess.
>
> Nice series. Does this also reduce module size on when building for
> SoC without PCI support?
Nope. On the contrary, there is a small increase due to the new rt2800mmio
module (compiled for RT305x SoCs):
before:
text data bss dec hex filename
7232 96 16 7344 1cb0 rt2800pci.o
after:
text data bss dec hex filename
1934 100 16 2050 802 rt2800soc.o
5664 0 0 5664 1620 rt2800mmio.o
delta:
+366 +4 0 +370
-Gabor
prev parent reply other threads:[~2013-10-18 7:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 7:42 [PATCH 00/21] rt2x00: separate rt2800 PCI and SoC driver Gabor Juhos
2013-10-17 7:42 ` [PATCH 01/21] rt2x00: create a new module for rt2800 MMIO code Gabor Juhos
2013-10-17 7:42 ` [PATCH 02/21] rt2x00: rt2800pci: use rt2800mmio prefix for TX descriptor functions Gabor Juhos
2013-10-17 7:42 ` [PATCH 03/21] rt2x00: rt2800pci: move TX descriptor functions to the rt2800mmio module Gabor Juhos
2013-10-17 7:42 ` [PATCH 04/21] rt2x00: rt2800pci: use rt2800mmio prefix for RX control handler functions Gabor Juhos
2013-10-17 7:42 ` [PATCH 05/21] rt2x00: rt2800pci: move RX control handler functions to the rt2800mmio module Gabor Juhos
2013-10-17 7:42 ` [PATCH 06/21] rt2x00: rt2800pci: use rt2800mmio prefix for interrupt functions Gabor Juhos
2013-10-17 7:42 ` [PATCH 07/21] rt2x00: rt2800pci: move interrupt functions to the rt2800mmio module Gabor Juhos
2013-10-17 7:42 ` [PATCH 08/21] rt2x00: rt2800pci: use rt2800mmio prefix for queue functions Gabor Juhos
2013-10-17 7:42 ` [PATCH 09/21] rt2x00: rt2800pci: move queue functions to the rt2800mmio module Gabor Juhos
2013-10-17 7:42 ` [PATCH 10/21] rt2x00: rt2800pci: use rt2800mmio prefix for initialization functions Gabor Juhos
2013-10-17 7:42 ` [PATCH 11/21] rt2x00: rt2800pci: move initialization functions to the rt2800mmio module Gabor Juhos
2013-10-17 7:42 ` [PATCH 12/21] rt2x00: rt2800pci: use separate ops for the SoC driver Gabor Juhos
2013-10-17 7:42 ` [PATCH 13/21] rt2x00: rt2800pci: use separate read_eeprom callback for SoC devices Gabor Juhos
2013-10-17 7:42 ` [PATCH 14/21] rt2x00: rt2800pci: use separate firmware callbacks " Gabor Juhos
2013-10-17 7:42 ` [PATCH 15/21] rt2x00: rt2800pci: use separate set_state callback " Gabor Juhos
2013-10-17 7:42 ` [PATCH 16/21] rt2x00: rt2800pci: rename rt2800pci_disable_radio function Gabor Juhos
2013-10-17 7:42 ` [PATCH 17/21] rt2x00: rt2800pci: split rt2800pci_enable_radio function Gabor Juhos
2013-10-17 7:42 ` [PATCH 18/21] rt2x00: rt2800pci: move rt2800mmio_enable_radio function to another module Gabor Juhos
2013-10-17 7:42 ` [PATCH 19/21] rt2x00: rt2800pci: use separate hwcrypt_disabled callback for SoC devices Gabor Juhos
2013-10-17 7:42 ` [PATCH 20/21] rt2x00: rt2800pci: move SoC specific code into a separate module Gabor Juhos
2013-10-17 7:42 ` [PATCH 21/21] rt2x00: rt2800pci: use module_pci_driver macro Gabor Juhos
2013-10-17 14:31 ` [PATCH 00/21] rt2x00: separate rt2800 PCI and SoC driver Helmut Schaa
2013-10-18 7:57 ` Gabor Juhos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5260E9F4.2070204@openwrt.org \
--to=juhosg@openwrt.org \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.