From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45544)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1VX51y-0007sR-Gj
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 04:03:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1VX51p-0002DC-KN
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 04:03:34 -0400
Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:60713)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1VX51p-0002CB-8c
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 04:03:25 -0400
Received: from /spool/local
	by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Fri, 18 Oct 2013 09:03:21 +0100
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 83B512190074
	for <qemu-devel@nongnu.org>; Fri, 18 Oct 2013 09:03:18 +0100 (BST)
Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com
	[9.149.37.228])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id r9I835oM46989486
	for <qemu-devel@nongnu.org>; Fri, 18 Oct 2013 08:03:05 GMT
Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id r9I83Hu1020243
	for <qemu-devel@nongnu.org>; Fri, 18 Oct 2013 02:03:18 -0600
Message-ID: <5260EB43.4090607@de.ibm.com>
Date: Fri, 18 Oct 2013 10:03:15 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <CAPM=9txo2k4jMha+u2azexYwTJiJ9ga8kNnPNTJ3Lei7AOa=Yg@mail.gmail.com>
In-Reply-To: <CAPM=9txo2k4jMha+u2azexYwTJiJ9ga8kNnPNTJ3Lei7AOa=Yg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] virtio-blk wierd memcpy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dave Airlie <airlied@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 17/10/13 20:49, Dave Airlie wrote:
> In my failing attempts to valgrind qemu (how to people live like
> this?), I spotted this in the logs

What are the failures? Do you use emulation or KVM? I know that there seems to be some issues regarding
async I/O but otherwise that that it seems to run. (Some KVm ioctls miss special handling, but in
general it should work).
> 
> ==19521== Source and destination overlap in memcpy(0x31d38938, 0x31d38938, 64)
> ==19521==    at 0x4A0A343: memcpy@@GLIBC_2.14 (in
> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==19521==    by 0x42774E: virtio_blk_device_init (virtio-blk.c:686)
> ==19521==    by 0x46EE9E: virtio_device_init (virtio.c:1158)
> ==19521==    by 0x25405E: device_realize (qdev.c:178)
> ==19521==    by 0x2559B5: device_set_realized (qdev.c:699)
> ==19521==    by 0x3A819B: property_set_bool (object.c:1315)
> ==19521==    by 0x3A6CE0: object_property_set (object.c:803)
> 
> The memcpy looks completely superfluous.
> 
> Dave.
>