From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36145)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VX6VG-0003Di-Ib
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:38:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VX6VA-0007Qk-DL
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:37:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9640)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VX6VA-0007Qb-4d
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:37:48 -0400
Message-ID: <52610165.3040809@redhat.com>
Date: Fri, 18 Oct 2013 11:37:41 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1382058681-14957-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1382058681-14957-6-git-send-email-xiawenc@linux.vnet.ibm.com>
In-Reply-To: <1382058681-14957-6-git-send-email-xiawenc@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/13] error: define struct Error in only
	one place
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

Il 18/10/2013 03:11, Wenchao Xia ha scritto:
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  include/qapi/error.h |    5 ++++-
>  qobject/qerror.c     |    7 -------
>  util/error.c         |    6 ------
>  3 files changed, 4 insertions(+), 14 deletions(-)
> 
> diff --git a/include/qapi/error.h b/include/qapi/error.h
> index 7d4c696..8688aaf 100644
> --- a/include/qapi/error.h
> +++ b/include/qapi/error.h
> @@ -20,7 +20,10 @@
>   * A class representing internal errors within QEMU.  An error has a ErrorClass
>   * code and a human message.
>   */
> -typedef struct Error Error;
> +typedef struct Error {
> +    char *msg;
> +    ErrorClass err_class;
> +} Error;

Please add a comment that it should be treated as an opaque type.

Paolo

>  
>  /**
>   * Set an indirect pointer to an error given a ErrorClass value and a
> diff --git a/qobject/qerror.c b/qobject/qerror.c
> index 3aee1cf..5b487f3 100644
> --- a/qobject/qerror.c
> +++ b/qobject/qerror.c
> @@ -97,13 +97,6 @@ void qerror_report(ErrorClass eclass, const char *fmt, ...)
>      }
>  }
>  
> -/* Evil... */
> -struct Error
> -{
> -    char *msg;
> -    ErrorClass err_class;
> -};
> -
>  void qerror_report_err(Error *err)
>  {
>      QError *qerr;
> diff --git a/util/error.c b/util/error.c
> index ec0faa6..da0d221 100644
> --- a/util/error.c
> +++ b/util/error.c
> @@ -17,12 +17,6 @@
>  #include "qapi-types.h"
>  #include "qapi/qmp/qerror.h"
>  
> -struct Error
> -{
> -    char *msg;
> -    ErrorClass err_class;
> -};
> -
>  void error_set(Error **errp, ErrorClass err_class, const char *fmt, ...)
>  {
>      Error *err;
>