From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX6dN-0008Nq-Qk for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:46:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VX6dG-00028C-2V for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:46:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX6dF-000283-RF for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:46:10 -0400 Message-ID: <5261035A.5060705@redhat.com> Date: Fri, 18 Oct 2013 11:46:02 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1382058681-14957-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382058681-14957-11-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1382058681-14957-11-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/13] qerror: deref once in qerror_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com Il 18/10/2013 03:11, Wenchao Xia ha scritto: > Signed-off-by: Wenchao Xia > --- > qobject/qerror.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/qobject/qerror.c b/qobject/qerror.c > index 5b487f3..685167a 100644 > --- a/qobject/qerror.c > +++ b/qobject/qerror.c > @@ -77,7 +77,6 @@ static void qerror_print(QError *qerror) > loc_push_restore(&qerror->loc); > error_report("%s", qstring_get_str(qstring)); > loc_pop(&qerror->loc); > - QDECREF(qstring); > } > > void qerror_report(ErrorClass eclass, const char *fmt, ...) > Why isn't this a memory leak? Paolo