From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX6jP-0004wt-LW for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:52:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VX6jJ-000496-NF for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:52:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX6jJ-000492-El for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:52:25 -0400 Message-ID: <526104D1.8050100@redhat.com> Date: Fri, 18 Oct 2013 11:52:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1382058681-14957-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382058681-14957-14-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1382058681-14957-14-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/13] stubs: do not call monitor_printf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com Il 18/10/2013 03:11, Wenchao Xia ha scritto: > stubs/pci-drive-host-add.o is packaged together with /stubs/mon-printf.o > so it would not work normal, remove it. > > Signed-off-by: Wenchao Xia > --- > stubs/pci-drive-hot-add.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/stubs/pci-drive-hot-add.c b/stubs/pci-drive-hot-add.c > index 1d98145..af4612f 100644 > --- a/stubs/pci-drive-hot-add.c > +++ b/stubs/pci-drive-hot-add.c > @@ -5,6 +5,5 @@ > int pci_drive_hot_add(Monitor *mon, const QDict *qdict, DriveInfo *dinfo) > { > /* On non-x86 we don't do PCI hotplug */ > - monitor_printf(mon, "Can't hot-add drive to type %d\n", dinfo->type); > return -1; > } > This is wrong; stubs are independent, that's why each of them is in its own C file. When linking a version of QEMU that does not have pci_drive_hot_add, this function will call the monitor_printf from QEMU. Paolo