Re: [PATCH RFC] media: rc: OF: Add Generic bindings for remote-control

[srinivas kandagatla <srinivas.kandagatla@st.com>]

Thanks Mark,

The blocking issue for st-rc driver is now closed.

On 18/10/13 12:37, Mark Rutland wrote:
>>
>> Mauro C. had an option that this is not a real use-case and let's not
>> overdesign the API, thinking on a possible scenario that may never happen.
>>
>> Do you still think that this use case should be considered in this
>> discussion?
> 
> Given how simple a device we're attempting to describe, I'm not even
> sure it makes sense to have a class of binding. We could leave this to
> individual device bindings for the moment.

Its clear.
>>
>> my_keymap: keymap {
>> 	rc-keymap-name = "my-keymap";
>> 	rc-codes	= 	<0x12, KEY_POWER,
>> 				0x01, KEY_TV,
>> 				0x15, KEY_DVD>;
>> 		...
>>  };
>>
>> my-rc-device {
>> 	compatible = "my,rc-device";
>> 	rc-keymap = <&my_keymap>;
>> 	rx-mode  = "infrared";
>> };
> 
> This may be ok, but we'll need to nail down the kaymap binding..

Yes, If Mauro thinks that rc keymaps from device tree is good feature we
can start a new discussion on this.

>> == Remote control Keymaps ==
>>
>> properties:
>> 	- rc-keymap-name: 	Should be the name of the keymap.
>> 	- rc-keymaps:		Should be an array of pair of scan code and actual key
>> code with first cell representing rc scan code and second cell
>> representing actual keycode.
> 
> Is one cell always enough for any scan code (or any actual keycode)?
> 
> As the format of the scan code will be device-specific, should this be
> under the node for the device? Are we likely to have multiple rc devices
> in a single system that can share a keymap?

I will let Mauro answer this.
> 
> What's the format of the actual keycode? What values are valid?
> 
>>
>> example:
>>
>> my_keymap: keymap {
>> 	rc-keymap-name = "my-keymap";
>> 	rc-keymaps	= 	<0x12, KEY_POWER,
>> 				0x01, KEY_TV,
>> 				0x15, KEY_DVD>;
>> 		...
>>  };
> 
> Please bracket list entries individually (it makes it far easier for
> humans to read arbitrary lists in dt, regardless of how consistent this
> may be).
> 
> Also, commas shouldn't be between brackets, dtc will barf if they're
> there.
> 
> So this should be something like:
> 
> 	rc-keymaps = <0x12 KEY_POWER>,
> 	             <0x01 KEY_TV>,
> 	             <0x15 KEY_DVD>;
> 

I agree this is much readable.

>>
>> my-rc-device {
>> 	compatible = "my,rc-device";
>> 	rc-keymap = <&my_keymap>;
>> 	rx-mode  = "infrared";
>> };
> 
> Thanks,
> Mark.
> 
>