From: Larry Finger <Larry.Finger@lwfinger.net>
To: Felipe Pena <felipensp@gmail.com>,
Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: net: wireless: rtlwifi: Fix wrong assignment
Date: Fri, 18 Oct 2013 17:27:34 -0500 [thread overview]
Message-ID: <5261B5D6.2020002@lwfinger.net> (raw)
In-Reply-To: <1382134538-3719-1-git-send-email-felipensp@gmail.com>
On 10/18/2013 05:15 PM, Felipe Pena wrote:
> There is a typo in the struct member name on assignment when checking
> rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20_40, the check uses pwrgroup_ht40
> for bound limit and uses pwrgroup_ht20 when assigning instead.
>
> Signed-off-by: Felipe Pena <felipensp@gmail.com>
> ---
> drivers/net/wireless/rtlwifi/rtl8192se/rf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/rf.c b/drivers/net/wireless/rtlwifi/rtl8192se/rf.c
> index 5061f1d..92d38ab 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192se/rf.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192se/rf.c
> @@ -265,7 +265,7 @@ static void _rtl92s_get_txpower_writeval_byregulatory(struct ieee80211_hw *hw,
> rtlefuse->pwrgroup_ht40
> [RF90_PATH_A][chnl - 1]) {
> pwrdiff_limit[i] =
> - rtlefuse->pwrgroup_ht20
> + rtlefuse->pwrgroup_ht40
> [RF90_PATH_A][chnl - 1];
> }
> } else {
Good catch. There is only one problem - by convention we skip
drivers/net/wireless in the subject. That would probably be OK, but you are
missing the rtl8192se part, which needs to be there. I suggest that you use the
subject "rtlwifi: rtl8192de: Fix wrong assignment".
Larry
next prev parent reply other threads:[~2013-10-18 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 22:15 [PATCH 1/1] drivers: net: wireless: rtlwifi: Fix wrong assignment Felipe Pena
2013-10-18 22:27 ` Larry Finger [this message]
2013-10-18 22:43 ` Felipe Pena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5261B5D6.2020002@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=felipensp@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.