All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Macke <sebastian@macke.de>
To: qemu-devel@nongnu.org, Jia Liu <proljc@gmail.com>
Cc: openrisc <openrisc@lists.openrisc.net>,
	"openrisc@lists.opencores.org" <openrisc@lists.opencores.org>
Subject: [Qemu-devel] [PATCH 1/2] target-openrisc: Remove executable flag for every page
Date: Fri, 18 Oct 2013 18:53:23 -0700	[thread overview]
Message-ID: <5261E613.2020900@macke.de> (raw)

Pages should be flagged executable only if the tlb executable flag is
set or the mmu is off.


Signed-off-by: Sebastian Macke <sebastian@macke.de>
---
  target-openrisc/mmu.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target-openrisc/mmu.c b/target-openrisc/mmu.c
index 22d7cbe..dd487bd 100644
--- a/target-openrisc/mmu.c
+++ b/target-openrisc/mmu.c
@@ -32,7 +32,7 @@ int cpu_openrisc_get_phys_nommu(OpenRISCCPU *cpu,
                                  int *prot, target_ulong address, int rw)
  {
      *physical = address;
-    *prot = PAGE_READ | PAGE_WRITE;
+    *prot = PAGE_READ | PAGE_WRITE | PAGE_EXEC;
      return TLBRET_MATCH;
  }
  @@ -187,7 +187,7 @@ int cpu_openrisc_handle_mmu_fault(CPUOpenRISCState
*env,
       if (ret == TLBRET_MATCH) {
          tlb_set_page(env, address & TARGET_PAGE_MASK,
-                     physical & TARGET_PAGE_MASK, prot | PAGE_EXEC,
+                     physical & TARGET_PAGE_MASK, prot,
                       mmu_idx, TARGET_PAGE_SIZE);
          ret = 0;
      } else if (ret < 0) {
-- 
1.7.9.5

                 reply	other threads:[~2013-10-19  1:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5261E613.2020900@macke.de \
    --to=sebastian@macke.de \
    --cc=openrisc@lists.opencores.org \
    --cc=openrisc@lists.openrisc.net \
    --cc=proljc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.