From: Ming Liu <ming.liu@windriver.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/4] strace: replace += with _append for appending to OVERRIDES variables
Date: Sun, 20 Oct 2013 19:08:09 +0800 [thread overview]
Message-ID: <5263B999.5040107@windriver.com> (raw)
In-Reply-To: <20131020105929.GA3697@jama>
On 10/20/2013 06:59 PM, Martin Jansa wrote:
> On Sun, Oct 20, 2013 at 06:48:31PM +0800, Ming Liu wrote:
>> In some cases, it's unfit to use "+=" in a conditional appending, we would
>> end up with the variable being set rather than being appended, which is not
>> it mean to.
>>
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>> meta/recipes-devtools/strace/strace_4.8.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-devtools/strace/strace_4.8.bb
>> index 79a4ad7..aad53b7 100644
>> --- a/meta/recipes-devtools/strace/strace_4.8.bb
>> +++ b/meta/recipes-devtools/strace/strace_4.8.bb
>> @@ -19,7 +19,7 @@ inherit autotools ptest
>> RDEPENDS_${PN}-ptest += "make"
>>
>> PACKAGECONFIG_class-target ?= "libaio"
>> -PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
>> +PACKAGECONFIG_append_class-target = " ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
> Doesn't using _append make it unnecessary harder to changed default value
> in .bbappend?
>
> Why not use
> PACKAGECONFIG_class-target ?= "libaio ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
> at least in this case?
Yes, it's reasonable and make things easy, I will do what you suggest in V1.
//Ming Liu
>
> Thanks
>
next prev parent reply other threads:[~2013-10-20 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 10:48 [PATCH 1/4] libarchive: replace += with _append for appending to OVERRIDES variables Ming Liu
2013-10-20 10:48 ` [PATCH 2/4] bzip2: " Ming Liu
2013-10-20 10:48 ` [PATCH 3/4] strace: " Ming Liu
2013-10-20 10:59 ` Martin Jansa
2013-10-20 11:08 ` Ming Liu [this message]
2013-10-20 10:48 ` [PATCH 4/4] nss: don't need set SRC_URI with both += and _append Ming Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5263B999.5040107@windriver.com \
--to=ming.liu@windriver.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.