Re: [dpdk-dev] [EXT] Re: [PATCH] maintainers: Update for OcteonTx2 DMA and EP

[Thomas Monjalon <thomas@monjalon.net>]

16/11/2020 19:28, Radha Mohan:
> On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 13/11/2020 20:18, Radha Mohan:
> > > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa <mchalla@marvell.com> wrote:
> > > From: Radha Mohan <mohun106@gmail.com>
> > > Sent: Tuesday, November 10, 2020 11:44 PM
> > > > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
> > > > >
> > > > > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> > > > >
> > > > > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > [...]
> > > > >Adding previous maintainers to ack.
> > > > Acked-by: Mahipal Challa <mchalla@marvell.com
> > > >
> > > > Thanks,
> > > > Mahipal
> > >
> > > Hi Thomas,
> > > Could you please pick this patch ?
> >
> > This low-priority patch has been sent 4 days ago,
> > and was acked by only 1 maintainer 3 days ago.
> >
> 
> It was acked by both the old maintainers Satha Koteshwar and Mahipal
> Challa. Maybe both of those emails didn't come on top of each other.

I missed one.

> > Why pushing? What is your fear exactly?
> 
> Just want to make the transfer of ownership official in the mainline.
> There's no fear I just normally wanted to send a reminder to you to
> pick as it might be missed inclusion. If there's a guarantee that all
> ack'ed patches will go automatically then I won't be sending any
> reminder emails in future.

It's OK to send reminder, but please wait at least a week.

> > Why the new maintainers candidates have 0 and 2 contributions
> > in git history?
> >
> These drivers requires some maintenance and likely expanded to support
> future chips from Marvell. So you will not see contributions right
> away.
> So to become a maintainer one has to have prior contributions ?

Yes: http://doc.dpdk.org/guides/contributing/patches.html#maintainers-and-sub-trees
"
Maintainers should have demonstrated a reasonable level of contributions or reviews to the component area. The maintainer should be confirmed by an ack from an established contributor.
"

> Kind of makes odd sense as these drivers are specific to our chip and we
> are changing ownership for maintaining them.
> I do not understand why you have an issue here?
> You don't like reminding then I understand.

I don't like how you push new unconfirmed maintainers.