From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59359)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VY5Sp-0006ys-63
	for qemu-devel@nongnu.org; Sun, 20 Oct 2013 22:43:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VY5Sg-0000j6-95
	for qemu-devel@nongnu.org; Sun, 20 Oct 2013 22:43:27 -0400
Received: from e23smtp08.au.ibm.com ([202.81.31.141]:39229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VY5Sf-0000hr-JY
	for qemu-devel@nongnu.org; Sun, 20 Oct 2013 22:43:18 -0400
Received: from /spool/local
	by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Mon, 21 Oct 2013 12:43:13 +1000
Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120])
	by d23dlp02.au.ibm.com (Postfix) with ESMTP id 3E5B22BB0052
	for <qemu-devel@nongnu.org>; Mon, 21 Oct 2013 13:43:10 +1100 (EST)
Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r9L2PxZN7733604
	for <qemu-devel@nongnu.org>; Mon, 21 Oct 2013 13:25:59 +1100
Received: from d23av04.au.ibm.com (localhost [127.0.0.1])
	by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	r9L2h9Um020888
	for <qemu-devel@nongnu.org>; Mon, 21 Oct 2013 13:43:09 +1100
Message-ID: <526494BC.2060508@linux.vnet.ibm.com>
Date: Mon, 21 Oct 2013 10:43:08 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1382058681-14957-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1382058681-14957-3-git-send-email-xiawenc@linux.vnet.ibm.com>
	<5261010A.80400@redhat.com>
In-Reply-To: <5261010A.80400@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 02/13] block: do not include monitor.h in
	block.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

于 2013/10/18 17:36, Paolo Bonzini 写道:
> Il 18/10/2013 03:11, Wenchao Xia ha scritto:
>> block_int.h already included it.
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> ---
>>   block.c |    1 -
>>   1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/block.c b/block.c
>> index 2c15e5d..e92a556 100644
>> --- a/block.c
>> +++ b/block.c
>> @@ -24,7 +24,6 @@
>>   #include "config-host.h"
>>   #include "qemu-common.h"
>>   #include "trace.h"
>> -#include "monitor/monitor.h"
>>   #include "block/block_int.h"
>>   #include "block/blockjob.h"
>>   #include "qemu/module.h"
>>
> Does this cause problems?  block.c uses monitor_protocol_event, so it's
> good to include the file directly instead of relying on other header files.
>
> Paolo
>
OK, will drop this patch.