All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan_Lynch@mentor.com (Nathan Lynch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] imx6q: fix emergency restart
Date: Mon, 21 Oct 2013 09:49:28 -0500	[thread overview]
Message-ID: <52653EF8.8030902@mentor.com> (raw)
In-Reply-To: <20131020232217.GS25034@n2100.arm.linux.org.uk>

On 10/20/2013 06:22 PM, Russell King - ARM Linux wrote:
> On Thu, Oct 03, 2013 at 03:32:17PM -0500, Nathan Lynch wrote:
>> @@ -192,8 +188,15 @@ static void __init imx6q_1588_init(void)
>>  
>>  static void __init imx6q_init_machine(void)
>>  {
>> +	struct device_node *np;
>> +
>>  	imx6q_enet_phy_init();
>>  
>> +	np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-wdt");
>> +	if (np)
>> +		wdog_base = of_iomap(np, 0);
>> +	pr_info("%s: wdog_base = %p\n", __func__, wdog_base);
> 
> I don't know whether this has been applied yet, but please don't add
> to the kernel messages unnecessarily; there's already enough of them
> and unless it provides something which is useful, it doesn't deserve
> to be at "info" level.  If you want it to report it for debugging,
> then please use the debugging level.

Yeah, sorry, it was just debug cruft I didn't intend to include in the
final patch.  Sloppy :(

      parent reply	other threads:[~2013-10-21 14:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 20:32 [PATCH] imx6q: fix emergency restart Nathan Lynch
2013-10-03 20:52 ` Nathan Lynch
2013-10-04  1:26 ` Fabio Estevam
2013-10-06  9:09 ` Shawn Guo
2013-10-20 23:22 ` Russell King - ARM Linux
2013-10-21  0:35   ` Shawn Guo
2013-10-21 14:49   ` Nathan Lynch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52653EF8.8030902@mentor.com \
    --to=nathan_lynch@mentor.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.