From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:58590 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066Ab3JUUU6 (ORCPT ); Mon, 21 Oct 2013 16:20:58 -0400 Message-ID: <52658CA7.5080104@iki.fi> Date: Mon, 21 Oct 2013 23:20:55 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Phil Carmody , Wolfram Sang CC: linux-media@vger.kernel.org Subject: Re: [PATCH] rtl2830: add parent for I2C adapter References: <1382386335-3879-1-git-send-email-crope@iki.fi> In-Reply-To: <1382386335-3879-1-git-send-email-crope@iki.fi> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello Phil and Wolfram, I found one of my drivers was crashing when DTV USB stick was plugged. Patch in that mail patch fixes the problem. I quickly looked possible I2C patches causing the problem and saw that one as most suspicions: commit 3923172b3d700486c1ca24df9c4c5405a83e2309 i2c: reduce parent checking to a NOOP in non-I2C_MUX case My config has no CONFIG_I2C_MUX set currently, but I am not sure how it has been earlier. Any idea? regards Antti On 21.10.2013 23:12, Antti Palosaari wrote: > i2c i2c-6: adapter [RTL2830 tuner I2C adapter] registered > BUG: unable to handle kernel NULL pointer dereference at 0000000000000220 > IP: [] i2c_register_adapter+0x130/0x390 [i2c_core] > > Signed-off-by: Antti Palosaari > --- > drivers/media/dvb-frontends/rtl2830.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/dvb-frontends/rtl2830.c b/drivers/media/dvb-frontends/rtl2830.c > index 362d26d..68ee70b 100644 > --- a/drivers/media/dvb-frontends/rtl2830.c > +++ b/drivers/media/dvb-frontends/rtl2830.c > @@ -700,6 +700,7 @@ struct dvb_frontend *rtl2830_attach(const struct rtl2830_config *cfg, > sizeof(priv->tuner_i2c_adapter.name)); > priv->tuner_i2c_adapter.algo = &rtl2830_tuner_i2c_algo; > priv->tuner_i2c_adapter.algo_data = NULL; > + priv->tuner_i2c_adapter.dev.parent = &i2c->dev; > i2c_set_adapdata(&priv->tuner_i2c_adapter, priv); > if (i2c_add_adapter(&priv->tuner_i2c_adapter) < 0) { > dev_err(&i2c->dev, > -- http://palosaari.fi/