From: Ming Liu <ming.liu@windriver.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH V4 3/3] screen: dynamically add or remove a entry to/from /etc/shells
Date: Tue, 22 Oct 2013 10:12:32 +0800 [thread overview]
Message-ID: <5265DF10.2020106@windriver.com> (raw)
In-Reply-To: <CAMKF1srMtfiN_dNRhnY8=cmTexkMpYFVHunnCr49ULvqdCdWdA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2176 bytes --]
On 10/22/2013 06:32 AM, Khem Raj wrote:
>
>
> On Sunday, October 20, 2013, Ming Liu <ming.liu@windriver.com
> <mailto:ming.liu@windriver.com>> wrote:
> > 1 Add base-files to RDEPENDS.
> > 2 Add pkg_postinst and pkg_postrm to add and remove a entry in
> > /etc/shells.
> >
>
> will it affect upgradability of the package which is providing
> /etc/shells ?
Yes, you are right, it will. So we need put /etc/shells to CONFFILES in
base-files package.
//Ming Liu
>
> > Signed-off-by: Ming Liu <ming.liu@windriver.com
> <mailto:ming.liu@windriver.com>>
> > ---
> > meta/recipes-extended/screen/screen_4.0.3.bb
> <http://screen_4.0.3.bb> | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/meta/recipes-extended/screen/screen_4.0.3.bb
> <http://screen_4.0.3.bb>
> b/meta/recipes-extended/screen/screen_4.0.3.bb <http://screen_4.0.3.bb>
> > index 1a7eb20..be42fb9 100644
> > --- a/meta/recipes-extended/screen/screen_4.0.3.bb
> <http://screen_4.0.3.bb>
> > +++ b/meta/recipes-extended/screen/screen_4.0.3.bb
> <http://screen_4.0.3.bb>
> > @@ -12,6 +12,8 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=0774d66808b0f602e94448108f59448b \
> > SECTION = "console/utils"
> > DEPENDS = "ncurses \
> > ${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
> > +RDEPENDS_${PN} = "base-files"
> > +
> > PR = "r3"
> >
> > SRC_URI = "${GNU_MIRROR}/screen/screen-${PV}.tar.gz;name=tarball \
> > @@ -41,3 +43,11 @@ do_install_append () {
> > fi
> > done
> > }
> > +
> > +pkg_postinst_${PN} () {
> > + grep -q "^${bindir}/screen$" $D${sysconfdir}/shells || echo
> ${bindir}/screen >> $D${sysconfdir}/shells
> > +}
> > +
> > +pkg_postrm_${PN} () {
> > + printf "$(grep -v "^${bindir}/screen$"
> $D${sysconfdir}/shells)\n" > $D${sysconfdir}/shells
> > +}
> > --
> > 1.8.4.1
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
[-- Attachment #2: Type: text/html, Size: 3912 bytes --]
prev parent reply other threads:[~2013-10-22 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 8:02 [PATCH V4 1/3] base-files: remove invalid entries from /etc/shells Ming Liu
2013-10-20 8:02 ` [PATCH V4 2/3] bash: dynamically add or remove a entry to/from /etc/shells Ming Liu
2013-10-20 8:02 ` [PATCH V4 3/3] screen: " Ming Liu
2013-10-21 22:32 ` Khem Raj
2013-10-22 2:12 ` Ming Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5265DF10.2020106@windriver.com \
--to=ming.liu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.