From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VYVNp-0001kX-Il
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 02:24:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VYVNh-0000qd-3O
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 02:24:01 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <526619E2.80008@redhat.com>
Date: Tue, 22 Oct 2013 07:23:30 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <5257F4DD.7000204@gmail.com> <5257F55A.50703@gmail.com>
In-Reply-To: <5257F55A.50703@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v2 01/13] Abandon GEN_VSX_* macros
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

Il 11/10/2013 13:55, Tom Musta ha scritto:
> This patch eliminates the GEN_VSX_LXVNX/GEN_VSX_STXVNX macros which
> did not provide significant value above the general GEN_HANDLER_E
> macro.
> 
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> ---
>  target-ppc/translate.c |   12 ++----------
>  1 files changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 66fcd80..bd5e89d 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -9518,17 +9518,9 @@ GEN_VAFORM_PAIRED(vmsumshm, vmsumshs, 20),
>  GEN_VAFORM_PAIRED(vsel, vperm, 21),
>  GEN_VAFORM_PAIRED(vmaddfp, vnmsubfp, 23),
> 
> -#undef  GEN_VSX_LXVNX
> -#define GEN_VSX_LXVNX(name, opc2,
> opc3)                                        \
> -  GEN_HANDLER_E(lxv##name, 0x1F, opc2, opc3, 0x00000000, PPC_NONE,
> PPC2_VSX)
> +GEN_HANDLER_E(lxvd2x, 0x1F, 0x0C, 0x1A, 0, PPC_NONE, PPC2_VSX),
> 
> -GEN_VSX_LXVNX(d2x, 0x0C, 0x1A),
> -
> -#undef  GEN_VSX_STXVNX
> -#define GEN_VSX_STXVNX(name, opc2,
> opc3)                                       \
> -  GEN_HANDLER_E(stxv##name, 0x1F, opc2, opc3, 0x00000000, PPC_NONE,
> PPC2_VSX)
> -
> -GEN_VSX_STXVNX(d2x, 0x0C, 0x1E),
> +GEN_HANDLER_E(stxvd2x, 0x1F, 0xC, 0x1E, 0, PPC_NONE, PPC2_VSX),
> 
>  #undef GEN_XX3FORM_DM
>  #define GEN_XX3FORM_DM(name, opc2, opc3) \

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>