From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43753)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VYVOq-0002oh-LA
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 02:25:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VYVOi-00019D-8y
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 02:25:04 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52661A1D.7070208@redhat.com>
Date: Tue, 22 Oct 2013 07:24:29 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <5257F4DD.7000204@gmail.com> <5257F5DE.8090507@gmail.com>
In-Reply-To: <5257F5DE.8090507@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v2 03/13] Add lxvdsx
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

Il 11/10/2013 13:58, Tom Musta ha scritto:
> This patch adds the Load VSX Vector Doubleword & Splat Indexed
> (lxvdsx) instruction.
> 
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> ---
>  target-ppc/translate.c |   16 ++++++++++++++++
>  1 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 6ee0d80..e5021cf 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -7038,6 +7038,21 @@ static void gen_lxvd2x(DisasContext *ctx)
>      tcg_temp_free(EA);
>  }
> 
> +static void gen_lxvdsx(DisasContext *ctx)
> +{
> +    TCGv EA;
> +    if (unlikely(!ctx->vsx_enabled)) {
> +        gen_exception(ctx, POWERPC_EXCP_VSXU);
> +        return;
> +    }
> +    gen_set_access_type(ctx, ACCESS_INT);
> +    EA = tcg_temp_new();
> +    gen_addr_reg_index(ctx, EA);
> +    gen_qemu_ld64(ctx, cpu_vsrh(xT(ctx->opcode)), EA);
> +    tcg_gen_mov_tl(cpu_vsrl(xT(ctx->opcode)), cpu_vsrh(xT(ctx->opcode)));
> +    tcg_temp_free(EA);
> +}
> +
>  static void gen_stxvd2x(DisasContext *ctx)
>  {
>      TCGv EA;
> @@ -9535,6 +9550,7 @@ GEN_VAFORM_PAIRED(vmaddfp, vnmsubfp, 23),
> 
>  GEN_HANDLER_E(lxsdx, 0x1F, 0x0C, 0x12, 0, PPC_NONE, PPC2_VSX),
>  GEN_HANDLER_E(lxvd2x, 0x1F, 0x0C, 0x1A, 0, PPC_NONE, PPC2_VSX),
> +GEN_HANDLER_E(lxvdsx, 0x1F, 0x0C, 0x0A, 0, PPC_NONE, PPC2_VSX),
> 
>  GEN_HANDLER_E(stxvd2x, 0x1F, 0xC, 0x1E, 0, PPC_NONE, PPC2_VSX),
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>