From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44778)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VYVTM-0005EE-Nu
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 02:29:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VYVTE-0002bC-9v
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 02:29:44 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52661B3A.5070103@redhat.com>
Date: Tue, 22 Oct 2013 07:29:14 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <5257F4DD.7000204@gmail.com> <5257F65B.6070100@gmail.com>
In-Reply-To: <5257F65B.6070100@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v2 05/13] Add stxsdx
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

Il 11/10/2013 14:00, Tom Musta ha scritto:
> This patch adds the Store VSX Scalar Doubleword Indexed (stxsdx)
> instruction.
> 
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> ---
>  target-ppc/translate.c |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 064cfa1..46b8380 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -7081,6 +7081,20 @@ static void gen_lxvw4x(DisasContext *ctx)
>      tcg_temp_free(tmp);
>  }
> 
> +static void gen_stxsdx(DisasContext *ctx)
> +{
> +    TCGv EA;
> +    if (unlikely(!ctx->vsx_enabled)) {
> +        gen_exception(ctx, POWERPC_EXCP_VSXU);
> +        return;
> +    }
> +    gen_set_access_type(ctx, ACCESS_INT);
> +    EA = tcg_temp_new();
> +    gen_addr_reg_index(ctx, EA);
> +    gen_qemu_st64(ctx, cpu_vsrh(xS(ctx->opcode)), EA);
> +    tcg_temp_free(EA);
> +}
> +
>  static void gen_stxvd2x(DisasContext *ctx)
>  {
>      TCGv EA;
> @@ -9581,6 +9595,7 @@ GEN_HANDLER_E(lxvd2x, 0x1F, 0x0C, 0x1A, 0,
> PPC_NONE, PPC2_VSX),
>  GEN_HANDLER_E(lxvdsx, 0x1F, 0x0C, 0x0A, 0, PPC_NONE, PPC2_VSX),
>  GEN_HANDLER_E(lxvw4x, 0x1F, 0x0C, 0x18, 0, PPC_NONE, PPC2_VSX),
> 
> +GEN_HANDLER_E(stxsdx, 0x1F, 0xC, 0x16, 0, PPC_NONE, PPC2_VSX),
>  GEN_HANDLER_E(stxvd2x, 0x1F, 0xC, 0x1E, 0, PPC_NONE, PPC2_VSX),
> 
>  #undef GEN_XX3FORM_DM

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>