From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYXRs-00034y-D0 for qemu-devel@nongnu.org; Tue, 22 Oct 2013 04:36:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYXRj-00008A-W9 for qemu-devel@nongnu.org; Tue, 22 Oct 2013 04:36:20 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:53923 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYXRj-00007k-Jl for qemu-devel@nongnu.org; Tue, 22 Oct 2013 04:36:11 -0400 Message-ID: <526638F9.8020107@kamp.de> Date: Tue, 22 Oct 2013 10:36:09 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1382430415-24844-1-git-send-email-pl@kamp.de> <5266387D.1080506@redhat.com> In-Reply-To: <5266387D.1080506@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-img: add special exit code if bdrv_check is not supported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com On 22.10.2013 10:34, Eric Blake wrote: > On 10/22/2013 09:26 AM, Peter Lieven wrote: >> currently it is not possible to distinguish by exitcode if there >> has been an error or if bdrv_check is not supported by the image >> format. Change the exitcode from 1 to 255 for the latter case. > Why 255? Sure, 'xargs' handles $?=255 differently than most other > status, but in general, $? > 128 starts to be ambiguous with death by > signal (on the other hand, most systems stop at 64 signals rather than > 128). Most applications that use differentiated exit status just use 1 > and 2, rather than 1 and 255. I would also be fine with 63. Someone started to make some choices for check->leaks, check->corruptions using 2,3, ... I wanted to avoid conflicts if someone adds a 4,5,6 ... Peter