From: Jaehoon Chung <jh80.chung@samsung.com>
To: Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
cjb@laptop.org, tgih.jun@samsung.com, linux-mmc@vger.kernel.org,
thomas.ab@samsung.com, grundler@chromium.org
Cc: dianders@chromium.org, sonnyrao@chromium.org,
Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
Subject: Re: [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment
Date: Tue, 22 Oct 2013 19:12:24 +0900 [thread overview]
Message-ID: <52664F88.50605@samsung.com> (raw)
In-Reply-To: <1382433116-22180-1-git-send-email-yuvaraj.cd@samsung.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Reported-by: Grant Grundler <grundler@chromium.org>
On 10/22/2013 06:11 PM, Yuvaraj Kumar C D wrote:
> commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning
> ddr_timing value to sdr_timing.This patch fix's this by reverting
> the sdr_timing assignment statement to the earlier location.
>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index d42e664..3423c5e 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -251,12 +251,13 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host)
> if (ret)
> return ret;
>
> + priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
> +
> ret = of_property_read_u32_array(np,
> "samsung,dw-mshc-ddr-timing", timing, 2);
> if (ret)
> return ret;
>
> - priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
> priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
> host->priv = priv;
> return 0;
>
next prev parent reply other threads:[~2013-10-22 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 9:11 [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment Yuvaraj Kumar C D
2013-10-22 10:12 ` Jaehoon Chung [this message]
2013-10-23 11:27 ` Seungwon Jeon
2013-10-27 2:38 ` Chris Ball
2013-10-28 5:18 ` Yuvaraj Kumar
2013-11-08 19:29 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52664F88.50605@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=dianders@chromium.org \
--cc=grundler@chromium.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sonnyrao@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=yuvaraj.cd@gmail.com \
--cc=yuvaraj.cd@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.