From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45550)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1VYbWx-0004AD-2Y
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 08:57:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1VYbWo-0004y5-Ea
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 08:57:51 -0400
Message-ID: <5266762A.2090207@gmail.com>
Date: Tue, 22 Oct 2013 07:57:14 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <5257F4DD.7000204@gmail.com> <5257F6E6.9050503@gmail.com>
	<52661BC2.6050505@redhat.com>
In-Reply-To: <52661BC2.6050505@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v2 07/13] Add VSX Scalar Move Instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 10/22/2013 1:31 AM, Paolo Bonzini wrote:
> Il 11/10/2013 14:02, Tom Musta ha scritto:
>>
>> +            case OP_CPSGN: {                                      \
>> +                TCGv_i64 xa = tcg_temp_new();                     \
>> +                tcg_gen_mov_i64(xa, cpu_vsrh(xA(ctx->opcode)));   \
>> +                tcg_gen_andi_i64(xa, xa, (sgn_mask));             \
>> +                tcg_gen_andi_i64(xb, xb, ~(sgn_mask));            \
>> +                tcg_gen_or_i64(xb, xb, xa);                       \
>> +                tcg_temp_free(xa);                                \
>> +                break;                                            \
>
> You might get slightly better generated code if you move the sgn_mask
> immediate to a temporary and then use and+andc.
>
> Paolo
>
Thank you for the suggestion, Paolo.  I will recode, retest and resubmit this one and patch 8.