From: Philippe Gerum <rpm@xenomai.org>
To: Kim De Mey <kim.demey@gmail.com>, xenomai@xenomai.org
Subject: Re: [Xenomai] [PATCH] Xenomai-forge: psos: extended object names
Date: Tue, 22 Oct 2013 16:03:40 +0200 [thread overview]
Message-ID: <526685BC.10801@xenomai.org> (raw)
In-Reply-To: <7a6b7aaae44e8e8cdd75.1382447102@devws164.be.alcatel-lucent.com>
On 10/22/2013 03:05 PM, Kim De Mey wrote:
> Extend object names with number to make them unique
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> Signed-off-by: Ronny Meeus <ronny.meeus@gmail.com>
> Signed-off-by: Kim De Mey <kim.demey@gmail.com>
>
> ---
>
> Although this is not a requirement for pSOS, it would be nice to have
> unique names for debugging purposes. This comes especially in the picture
> with the implementation of registry for pSOS. Without unique names no
> object with duplicate name will be added to registry. Unless changes
> are made to the creation of the files.
>
I'm ok with the intent, not with the implementation. Please check how
the alchemy API does this via alchemy_build_name().
This will keep the name generation in a single place, and also fix a
race in the current pSOS emulator code, which post-increments anon_*ids
in a sloppy non-atomic way.
--
Philippe.
next prev parent reply other threads:[~2013-10-22 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 13:05 [Xenomai] [PATCH] Xenomai-forge: psos: extended object names Kim De Mey
2013-10-22 14:03 ` Philippe Gerum [this message]
2013-10-22 14:45 ` Kim De Mey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526685BC.10801@xenomai.org \
--to=rpm@xenomai.org \
--cc=kim.demey@gmail.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.