All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: <linux-pci@vger.kernel.org>,
	"'Pratyush Anand'" <pratyush.anand@st.com>,
	"'Mohit KUMAR'" <mohit.kumar@st.com>,
	"'Ajay KHANDELWAL'" <ajay.khandelwal@st.com>
Subject: Re: [QUERY] Number of address translation regions in designware
Date: Tue, 22 Oct 2013 19:50:01 +0530	[thread overview]
Message-ID: <52668991.1020208@ti.com> (raw)
In-Reply-To: <000001cecee5$cbeafa10$63c0ee30$%han@samsung.com>

Hi Pratyush, Jingoo,

On Tuesday 22 October 2013 10:46 AM, Jingoo Han wrote:
> On Monday, October 21, 2013 10:28 PM, Kishon Vijay Abraham I wrote:
>>
>> Currently I see in pcie-designware.c we use only 2 ATU regions. We re-use
>> INDEX0 for mem outbound and cfg0, and INDEX1 for cfg1 and io. So I'd like to
>> know if in your platform, do you have only 2 address translation regions? In
>> DRA7xx we have 16 outbound regions and 4 inbound regions.
> 
> In Exynos, there are only 2 inbound and 2 outbound viewpoints.
> 
>> Also the same designware IP can be used as a EP also no? Shouldn't we move it
>> out of drivers/pci/host and allow it to be configured as EP also?
> 
> Currently, Exynos PCIe IP does not support EP mode.

Thanks for the information. I think we can do some optimization w.r.t address
translation regions. Will post a RFC soon.

One more query.
In dw_pcie_prog_viewport_cfg0/dw_pcie_prog_viewport_cfg1 functions, the *lower
target* is programmed to busdev. Is it for any specific reason?
I mean doing that will leave lot of holes in the PCIe address space.
IIUC, if we don't set that to busdev, consecutive pcie address space will be
used for each function no?

Thanks
Kishon

  reply	other threads:[~2013-10-22 14:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 13:28 [QUERY] Number of address translation regions in designware Kishon Vijay Abraham I
2013-10-22  4:36 ` Pratyush Anand
2013-10-22  5:16 ` Jingoo Han
2013-10-22 14:20   ` Kishon Vijay Abraham I [this message]
2013-10-23  4:36     ` Pratyush Anand
2013-10-23 15:45       ` Kishon Vijay Abraham I
2013-10-29  7:10         ` Pratyush Anand
2013-10-29 10:55           ` Kishon Vijay Abraham I
2013-10-29 16:14             ` Pratyush Anand
2013-11-06  8:42               ` Kishon Vijay Abraham I
2013-11-15  0:40                 ` Marek Vasut
2013-11-15  5:28                   ` Kishon Vijay Abraham I
2013-11-15  6:13                     ` Jingoo Han
2013-11-15 15:37                       ` Marek Vasut
2013-11-18  5:46                         ` Kishon Vijay Abraham I
2013-11-18 14:43                           ` Arnd Bergmann
2013-11-01 12:37           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52668991.1020208@ti.com \
    --to=kishon@ti.com \
    --cc=ajay.khandelwal@st.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=mohit.kumar@st.com \
    --cc=pratyush.anand@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.