Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma'

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]

On 10/22/2013 05:59 PM, mrhines@linux.vnet.ibm.com wrote:
> From: "Michael R. Hines" <mrhines@us.ibm.com>
> 
> As far as we can tell, all known bugs have been fixed,
> there as been very good participation in testing and running.
> 
> 1. Parallel RDMA migrations are working
> 2. IPv6 migration is working
> 3. Libvirt patches are ready
> 4. virt-test is working
> 
> Any objections to removing the experimental tag?
> 
> There is one remaining bug: qemu-system-i386 does not compile
> with RDMA: I have very zero access to 32-bit hardware
> using RDMA, so this hasn't been much of a priority. It seems
> safer to *not* submit non-testable patch rather than submit
> submit a fix just for the sake of compiling =)
>  
> Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
> ---

>  
>  TODO:
>  =====
> -1. 'migrate x-rdma:host:port' and '-incoming x-rdma' options will be
> +1. 'migrate rdma:host:port' and '-incoming rdma' options will be
>     renamed to 'rdma' after the experimental phase of this work has
>     completed upstream.

Shouldn't you remove step 1 and renumber the rest of the list
altogether, rather than just altering the comment to make it out-of-date?

> +++ b/qapi-schema.json
> @@ -615,7 +615,7 @@
>  #          This feature allows us to minimize migration traffic for certain work
>  #          loads, by sending compressed difference of the pages
>  #
> -# @x-rdma-pin-all: Controls whether or not the entire VM memory footprint is
> +# @rdma-pin-all: Controls whether or not the entire VM memory footprint is
>  #          mlock()'d on demand or all at once. Refer to docs/rdma.txt for usage.
>  #          Disabled by default. Experimental: may (or may not) be renamed after
>  #          further testing is complete. (since 1.6)

I'd also recommend tweaking this to say 'since 1.7', since the spelling
'rdma-pin-all' is new to this release.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]