All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
	Yann Bordenave <meow@meowstars.org>,
	qemu-devel@nongnu.org, Guillaume Subiron <maethor@subiron.org>
Subject: Re: [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses
Date: Tue, 22 Oct 2013 21:25:25 +0100	[thread overview]
Message-ID: <5266DF35.1050902@redhat.com> (raw)
In-Reply-To: <20131022191258.GH5890@type.youpi.perso.aquilenet.fr>

[-- Attachment #1: Type: text/plain, Size: 2141 bytes --]

On 10/22/2013 08:12 PM, Samuel Thibault wrote:
> I see.  So it would be something like this?
> 
> commit 1807466d691f281f430fbf8c0bbff6bf8073247d
> Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Date:   Tue Oct 22 21:11:46 2013 +0200
> 
>     qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses
>     
>     This patchs adds parameters to manage some new options in the qemu -net
>     command.
>     Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in
>     argument to the qemu command.
>     Defaults parameters are respectively fc00::2, fc00::, /64 and fc00::3.
>     
>     Signed-off-by: Yann Bordenave <meow@meowstars.org>
>     Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Yes, this looks better from the interface point of view (I didn't
closely review the code though, as I'm not a slirp expert).

>  { 'type': 'NetdevUserOptions',
>    'data': {
> -    '*hostname':  'str',
> -    '*restrict':  'bool',
> -    '*ip':        'str',
> -    '*net':       'str',
> -    '*host':      'str',
> -    '*tftp':      'str',
> -    '*bootfile':  'str',
> -    '*dhcpstart': 'str',
> -    '*dns':       'str',
> -    '*dnssearch': ['String'],
> -    '*smb':       'str',
> -    '*smbserver': 'str',
> -    '*hostfwd':   ['String'],
> -    '*guestfwd':  ['String'] } }
> +    '*hostname':        'str',
> +    '*restrict':        'bool',
> +    '*ip':              'str',
> +    '*net':             'str',
> +    '*host':            'str',
> +    '*tftp':            'str',
> +    '*bootfile':        'str',
> +    '*dhcpstart':       'str',
> +    '*dns':             'str',
> +    '*dnssearch':       ['String'],
> +    '*ip6-prefix':      'str',
> +    '*ip6-prefixlen':   'int',
> +    '*ip6-host':        'str',
> +    '*ip6-dns':         'str',
> +    '*smb':             'str',
> +    '*smbserver':       'str',
> +    '*hostfwd':         ['String'],
> +    '*guestfwd':        ['String'] } }
>  

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  reply	other threads:[~2013-10-22 20:25 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1374334058-27898-1-git-send-email-maethor@subiron.org>
2013-10-20 14:54 ` [Qemu-devel] [PATCH 00/16] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2013-10-20 14:56   ` [Qemu-devel] [PATCH 01/16] slirp: goto bad in udp_input if sosendto fails Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 02/16] slirp: Generalizing and neutralizing code before adding IPv6 stuff Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 04/16] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration Samuel Thibault
2013-10-23  7:51       ` Paolo Bonzini
2013-10-23 22:49         ` Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 06/16] slirp: Make Socket structure IPv6 compatible Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 07/16] slirp: Factorizing address translation Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup() Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 09/16] slirp: Make udp_attach IPv6 compatible Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 10/16] slirp: Adding IPv6 UDP support Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect() Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 12/16] slirp: Factorizing tcpiphdr structure with an union Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 13/16] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 14/16] slirp: Handle IPv6 in TCP functions Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 15/16] slirp: Adding IPv6 address for DNS relay Samuel Thibault
2013-10-20 14:56     ` [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses Samuel Thibault
2013-10-21 21:04       ` Eric Blake
2013-10-22 10:22         ` Samuel Thibault
2013-10-22 10:27           ` Eric Blake
2013-10-22 10:31             ` Samuel Thibault
2013-10-22 10:33               ` Eric Blake
2013-10-22 10:45                 ` Samuel Thibault
2013-10-22 10:48                   ` Eric Blake
2013-10-22 10:52                     ` Eric Blake
2013-10-22 14:11                       ` Samuel Thibault
2013-10-22 14:48                         ` Eric Blake
2013-10-22 19:12                           ` Samuel Thibault
2013-10-22 20:25                             ` Eric Blake [this message]
2013-11-17 15:04   ` [Qemu-devel] [PATCHv2 00/16] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 01/16] slirp: goto bad in udp_input if sosendto fails Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 02/16] slirp: Generalizing and neutralizing code before adding IPv6 stuff Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 04/16] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 06/16] slirp: Make Socket structure IPv6 compatible Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 07/16] slirp: Factorizing address translation Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup() Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 09/16] slirp: Make udp_attach IPv6 compatible Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 10/16] slirp: Adding IPv6 UDP support Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect() Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 12/16] slirp: Factorizing tcpiphdr structure with an union Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 13/16] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 14/16] slirp: Handle IPv6 in TCP functions Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 15/16] slirp: Adding IPv6 address for DNS relay Samuel Thibault
2013-11-17 15:04     ` [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses Samuel Thibault
2014-02-11 13:08     ` [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 01/16] slirp: goto bad in udp_input if sosendto fails Samuel Thibault
2014-06-11  8:55         ` [Qemu-devel] [PATCH] " Samuel Thibault
2014-06-12  5:47           ` Jan Kiszka
2014-06-14 19:45             ` Samuel Thibault
2014-07-11 10:18         ` Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 02/16] slirp: Generalizing and neutralizing code before adding IPv6 stuff Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 04/16] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 06/16] slirp: Make Socket structure IPv6 compatible Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 07/16] slirp: Factorizing address translation Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup() Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 09/16] slirp: Make udp_attach IPv6 compatible Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 10/16] slirp: Adding IPv6 UDP support Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect() Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 12/16] slirp: Factorizing tcpiphdr structure with an union Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 13/16] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 14/16] slirp: Handle IPv6 in TCP functions Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 15/16] slirp: Adding IPv6 address for DNS relay Samuel Thibault
2014-02-11 13:08       ` [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses Samuel Thibault
2014-03-27 21:42         ` Eric Blake
2014-02-11 13:50       ` [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode Eric Blake
2014-02-11 14:35         ` Samuel Thibault
2014-02-11 14:42           ` Max Filippov
2014-02-11 14:48             ` Max Filippov
2014-03-12  7:27       ` Jan Kiszka
2014-03-20  7:58         ` Stefan Hajnoczi
2014-03-20  9:03           ` Samuel Thibault
2014-04-04 18:20             ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5266DF35.1050902@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=maethor@subiron.org \
    --cc=meow@meowstars.org \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.