From: Anand Jain <Anand.Jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org,
chris.mason@fusionio.com, jbacik@fusionio.com
Subject: Re: [PATCH 1/2] btrfs-progs: make get_btrfs_mount callable
Date: Wed, 23 Oct 2013 10:11:41 +0800 [thread overview]
Message-ID: <5267305D.7030605@oracle.com> (raw)
In-Reply-To: <20131022144346.GV1032@twin.jikos.cz>
On 10/22/13 10:43 PM, David Sterba wrote:
> On Tue, Oct 22, 2013 at 01:53:21PM +0800, Anand Jain wrote:
>> get_btrfs_mount is reusable function but it is printing
>> errors, this removes it. Here the parent function of
>> open_path_or_dev_mnt does print error msg on error.
>
> Yeah, but then each caller should duplicate the is_block_device check to
> keep get_btrfs_mount silent. There should be 2 functions, one that does
> all the error checking and prints error messages and one that is silent
> and usable eg. from a library. I'll keep the patch as-is for now because
> there are no other users than open_path_or_dev_mnt and the function is
> not exported to library.
yeah. sounds good. certainly we do have opportunities
when we are on the lib functions.
Thanks, Anand
prev parent reply other threads:[~2013-10-23 2:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 5:53 [PATCH 1/2] btrfs-progs: make get_btrfs_mount callable Anand Jain
2013-10-22 5:53 ` [PATCH 2/2] btrfs-progs: filesystem show of specified mounted disk should work Anand Jain
2013-10-22 14:33 ` David Sterba
2013-10-23 2:08 ` Anand Jain
2013-10-24 14:51 ` David Sterba
2013-10-24 14:54 ` Hugo Mills
2013-10-24 17:21 ` Anand Jain
2013-10-22 16:39 ` David Sterba
2013-10-23 1:53 ` Anand Jain
2013-10-22 14:43 ` [PATCH 1/2] btrfs-progs: make get_btrfs_mount callable David Sterba
2013-10-23 2:11 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5267305D.7030605@oracle.com \
--to=anand.jain@oracle.com \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.