All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Lai <plai@codeaurora.org>
To: Vinod Koul <vinod.koul@intel.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH RESEND] ASoC: dont call dapm_sync while reporting jack always
Date: Tue, 22 Oct 2013 19:45:50 -0700	[thread overview]
Message-ID: <5267385E.6020007@codeaurora.org> (raw)
In-Reply-To: <20131022153654.GQ14013@intel.com>

On 10/22/2013 8:36 AM, Vinod Koul wrote:
> On Tue, Oct 22, 2013 at 09:32:23AM +0100, Mark Brown wrote:
>> On Mon, Oct 21, 2013 at 07:07:34PM +0530, Vinod Koul wrote:
>>> While reporting the jack status snd_soc_jack_report() invokes snd_soc_dapm_sync()
>>> always. This should be required when we have pins associated with jack and
>>> reporting enables or disables these.
>>> So add a check for this case
>>
>> Applied, thanks.  It'd be good when doing things like this to say what
>> the advantage is; with DAPM the general thing is that it gets called a
>> lot so it should be cheap enough to just call all the time.
> Okay, my thoughts were that it was obvious. We saw an issue when monkey testing
> with jack, bunch of dapm_sync's got triggered (insertion, reroute from usermode,
> removal, again reroute from usermode, and so on). The insertion and removal ones
> were quite not required for cases with no pins
>
We observed the same thing on our side and create another report API
which does not call snd_soc_dapm_sync() :)
Thanks for working out a better solution

Thanks
Patrick
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>


-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2013-10-23  2:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 13:37 [PATCH RESEND] ASoC: dont call dapm_sync while reporting jack always Vinod Koul
2013-10-22  8:32 ` Mark Brown
2013-10-22 15:36   ` Vinod Koul
2013-10-23  2:45     ` Patrick Lai [this message]
2013-10-23  8:25     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5267385E.6020007@codeaurora.org \
    --to=plai@codeaurora.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.