All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kevin Hilman <khilman@linaro.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Archit Taneja <archit@ti.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Async runtime put in __device_release_driver()
Date: Wed, 23 Oct 2013 13:11:43 +0300	[thread overview]
Message-ID: <5267A0DF.7080604@ti.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

Hi,

I was debugging why clocks were left enabled after removing omapdss
driver, and I found this commit:

fa180eb448fa263cf18dd930143b515d27d70d7b (PM / Runtime: Idle devices
asynchronously after probe|release)

I don't understand how that is supposed to work.

When a driver is removed, instead of using pm_runtime_put_sync() the
commit uses pm_runtime_put(), so the runtime_suspend call is queued. But
who is going to handle the queued suspend call, as the driver is already
removed? At least in my case, obviously nobody, as I only get
runtime_resume call in my driver, never the runtime_suspend.

Is there something I need to add to my driver to make this work, or
should that part of the patch be reverted?

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

             reply	other threads:[~2013-10-23 10:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23 10:11 Tomi Valkeinen [this message]
2013-11-05 21:29 ` Async runtime put in __device_release_driver() Ulf Hansson
2013-11-06  7:51   ` Tomi Valkeinen
2013-11-06 22:01     ` Rafael J. Wysocki
2013-11-06 22:02       ` Alan Stern
2013-11-06 22:19         ` Rafael J. Wysocki
2013-11-06 22:48           ` Ulf Hansson
2013-11-07  0:16             ` Rafael J. Wysocki
2013-11-07  0:21               ` Kevin Hilman
2013-11-07  1:05                 ` Rafael J. Wysocki
2013-11-07  8:18                   ` Ulf Hansson
2013-11-07 18:55                     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5267A0DF.7080604@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=archit@ti.com \
    --cc=khilman@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.