From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: "linux-rdma
(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [PATCH opensm] Resend trap 144 when detecting remote MASTER SM with lower priority
Date: Wed, 23 Oct 2013 10:38:17 -0400 [thread overview]
Message-ID: <5267DF59.7000809@dev.mellanox.co.il> (raw)
From: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Remote MASTER SM might not get trap 144 and therefore never perform a HANDOVER.
The patch solves this by resending trap 144 when receiving GetResp(SMInfo) to
a remote MASTER SM after polling timeout expires.
Signed-off-by: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
opensm/osm_sminfo_rcv.c | 17 +++++++++++++----
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/opensm/osm_sminfo_rcv.c b/opensm/osm_sminfo_rcv.c
index 2fee359..16d2a4c 100644
--- a/opensm/osm_sminfo_rcv.c
+++ b/opensm/osm_sminfo_rcv.c
@@ -383,11 +383,20 @@ static void smi_rcv_process_get_sm(IN osm_sm_t * sm,
switch (ib_sminfo_get_state(p_smi)) {
case IB_SMINFO_STATE_MASTER:
/* If this is a response due to our polling, this means that we are
- waiting for a handover from this SM, and it is still alive -
- signal that. */
- if (sm->p_polling_sm)
+ * waiting for a handover from this SM, and it is still alive -
+ * signal that. If we detected the remote SM with higher priority
+ * we should init a heavy sweep in order to go STANDBY. If we
+ * detected a remote SM with lower priority, we should resend trap144
+ * as it might not get it and we don't want to wait for a HANDOVER
+ * forever.
+ */
+ if (sm->p_polling_sm) {
+ if (smi_rcv_remote_sm_is_higher(sm, p_smi))
+ sm->p_subn->force_heavy_sweep = TRUE;
+ else
+ osm_send_trap144(sm, TRAP_144_MASK_SM_PRIORITY_CHANGE);
osm_sm_state_mgr_signal_master_is_alive(sm);
- else {
+ } else {
/* This is a response we got while sweeping the subnet.
*
* If this is during a heavy sweep, we will handle a case of
--
1.7.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2013-10-23 14:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5267DF59.7000809@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.