From mboxrd@z Thu Jan 1 00:00:00 1970 From: denis@eukrea.com (Denis Carikli) Date: Wed, 23 Oct 2013 16:48:51 +0200 Subject: [Patch v2][ 03/37] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_* In-Reply-To: <20131018074631.GO13047@intel.com> References: <1382022155-21954-1-git-send-email-denis@eukrea.com> <1382022155-21954-4-git-send-email-denis@eukrea.com> <20131018074631.GO13047@intel.com> Message-ID: <5267E1D3.5060803@eukrea.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 10/18/2013 09:46 AM, Ville Syrj?l? wrote: >> +#define DRM_MODE_FLAG_PDATEN (1<<22) >> +#define DRM_MODE_FLAG_NDATEN (1<<23) >> +#define DRM_MODE_FLAG_PPIXDATEDGE (1<<24) >> +#define DRM_MODE_FLAG_NPIXDATEDGE (1<<25) > > Do we really need to make this stuff visible to userspace? > And there's no documentation to explain any of it. DRM_MODE_FLAG_PDATEN and DRM_MODE_FLAG_NDATEN were meant to represent the data enable polarity. DRM_MODE_FLAG_PPIXDATEDGE and DRM_MODE_FLAG_NPIXDATEDGE were meant to represent the clock polarity. What would you recommend to represent theses polarities? Denis. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Carikli Subject: Re: [Patch v2][ 03/37] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_* Date: Wed, 23 Oct 2013 16:48:51 +0200 Message-ID: <5267E1D3.5060803@eukrea.com> References: <1382022155-21954-1-git-send-email-denis@eukrea.com> <1382022155-21954-4-git-send-email-denis@eukrea.com> <20131018074631.GO13047@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20131018074631.GO13047@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?ISO-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: Fabio Estevam , =?ISO-8859-1?Q?Eric_B=E9nard?= , Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, dri-devel@lists.freedesktop.org, Sascha Hauer , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org Hi, On 10/18/2013 09:46 AM, Ville Syrj=E4l=E4 wrote: >> +#define DRM_MODE_FLAG_PDATEN (1<<22) >> +#define DRM_MODE_FLAG_NDATEN (1<<23) >> +#define DRM_MODE_FLAG_PPIXDATEDGE (1<<24) >> +#define DRM_MODE_FLAG_NPIXDATEDGE (1<<25) > > Do we really need to make this stuff visible to userspace? > And there's no documentation to explain any of it. DRM_MODE_FLAG_PDATEN and DRM_MODE_FLAG_NDATEN were meant to represent = the data enable polarity. DRM_MODE_FLAG_PPIXDATEDGE and DRM_MODE_FLAG_NPIXDATEDGE were meant to = represent the clock polarity. What would you recommend to represent theses polarities? Denis.