All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: SCSI development list <linux-scsi@vger.kernel.org>
Subject: [RFC]: scsi_error: interruptible scsi_block_when_processing_errors()
Date: Wed, 23 Oct 2013 12:02:18 -0400	[thread overview]
Message-ID: <5267F30A.1080800@interlog.com> (raw)

The existing scsi_block_when_processing_errors() function
in scsi_error.c does a non-interruptible wait on the
host_wait work queue. That call is made from many places
in the scsi subsystem ULDs (e.g. the sg driver).

In many cases (e.g. sg_open()) there is a direct path
back to the user space. So why hang open(sg_device) calls
(that don't use O_NONBLOCK) in an non-interruptible call
for what might be a long time.

Apart from signal indications, such a non-interruptible
version of scsi_block_when_processing_errors() could return
useful (possibly negated) errno_s, for example indicating
the device in question had been detached or timed out
(possibly because the HBA was being reset).

Thoughts?

Doug Gilbert


                 reply	other threads:[~2013-10-23 16:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5267F30A.1080800@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.