All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com,
	qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCHv6 17/17] block/raw: copy BlockLimits on raw_open
Date: Thu, 24 Oct 2013 11:12:27 +0200	[thread overview]
Message-ID: <5268E47B.4060107@kamp.de> (raw)
In-Reply-To: <5268E41C.9050406@redhat.com>

On 24.10.2013 11:10, Paolo Bonzini wrote:
> Il 24/10/2013 08:46, Peter Lieven ha scritto:
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>>   block/raw_bsd.c |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/block/raw_bsd.c b/block/raw_bsd.c
>> index b0dd23f..49ac18c 100644
>> --- a/block/raw_bsd.c
>> +++ b/block/raw_bsd.c
>> @@ -150,6 +150,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int flags,
>>                       Error **errp)
>>   {
>>       bs->sg = bs->file->sg;
>> +    bs->bl = bs->file->bl;
>>       return 0;
>>   }
>>   
>>
> This must be moved before the introduction of BlockLimits in the iscsi
> driver, or patches that use BlockLimits in block.c will not have any effect.
You are the first to mention this. I was thinking the whole series will
be seen as once so it shouldn't matter.

Peter

  reply	other threads:[~2013-10-24  9:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24  7:46 [Qemu-devel] [PATCHv6 00/17] block: logical block provisioning enhancements Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 01/17] block: make BdrvRequestFlags public Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 02/17] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 03/17] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 04/17] block: add logical block provisioning info to BlockDriverInfo Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 05/17] block: add wrappers for logical block provisioning information Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 06/17] block/iscsi: add .bdrv_get_info Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 07/17] block: add BlockLimits structure to BlockDriverState Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 08/17] block: honour BlockLimits in bdrv_co_do_write_zeroes Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 09/17] block: honour BlockLimits in bdrv_co_discard Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 10/17] iscsi: simplify iscsi_co_discard Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 11/17] iscsi: set limits in BlockDriverState Peter Lieven
2013-10-24  9:07   ` Paolo Bonzini
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 12/17] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 13/17] block: introduce bdrv_make_zero Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-10-24  9:09   ` Paolo Bonzini
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 15/17] qemu-img: add support for fully allocated images Peter Lieven
2013-10-24  9:12   ` Paolo Bonzini
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 16/17] qemu-img: conditionally zero out target on convert Peter Lieven
2013-10-24  9:13   ` Paolo Bonzini
2013-10-24  9:17     ` Peter Lieven
2013-10-24  7:46 ` [Qemu-devel] [PATCHv6 17/17] block/raw: copy BlockLimits on raw_open Peter Lieven
2013-10-24  9:10   ` Paolo Bonzini
2013-10-24  9:12     ` Peter Lieven [this message]
2013-10-24 10:06       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5268E47B.4060107@kamp.de \
    --to=pl@kamp.de \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.