All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 8/9] iio: dac: mcp4725: Remove redundant code
Date: Thu, 24 Oct 2013 14:53:23 +0100	[thread overview]
Message-ID: <52692653.1060508@kernel.org> (raw)
In-Reply-To: <1382615615-20153-8-git-send-email-sachin.kamat@linaro.org>

On 10/24/13 12:53, Sachin Kamat wrote:
> Remove an inconsequential print message and return directly
> thereby cleaning up some code.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the toreg branch of iio.git
(same comment on does anyone care about the message drop?)
> ---
>  drivers/iio/dac/mcp4725.c |    8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
> index d982752..9f57ae8 100644
> --- a/drivers/iio/dac/mcp4725.c
> +++ b/drivers/iio/dac/mcp4725.c
> @@ -320,13 +320,7 @@ static int mcp4725_probe(struct i2c_client *client,
>  	data->powerdown_mode = pd ? pd-1 : 2; /* 500kohm_to_gnd */
>  	data->dac_value = (inbuf[1] << 4) | (inbuf[2] >> 4);
>  
> -	err = iio_device_register(indio_dev);
> -	if (err)
> -		return err;
> -
> -	dev_info(&client->dev, "MCP4725 DAC registered\n");
> -
> -	return 0;
> +	return iio_device_register(indio_dev);
>  }
>  
>  static int mcp4725_remove(struct i2c_client *client)
> 

  reply	other threads:[~2013-10-24 12:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 11:53 [PATCH 1/9] iio: core: Use pr_err instead of printk Sachin Kamat
2013-10-24 11:53 ` [PATCH 2/9] iio: core: Add misssing braces Sachin Kamat
2013-10-24 13:44   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 3/9] iio: accel: kxsd9: Remove redundant variable Sachin Kamat
2013-10-24 13:44   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 4/9] iio: adc: twl6030-gpadc: Remove redundant code Sachin Kamat
2013-10-24 13:49   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 5/9] iio: dac: ad5421: " Sachin Kamat
2013-10-24 13:51   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 6/9] iio: dac: ad5755: " Sachin Kamat
2013-10-24 13:51   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 7/9] iio: dac: max517: Remove redundant variable Sachin Kamat
2013-10-24 13:52   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 8/9] iio: dac: mcp4725: Remove redundant code Sachin Kamat
2013-10-24 13:53   ` Jonathan Cameron [this message]
2013-10-24 11:53 ` [PATCH 9/9] iio: light: vcnl4000: " Sachin Kamat
2013-10-24 13:53   ` Jonathan Cameron
2013-10-24 13:41 ` [PATCH 1/9] iio: core: Use pr_err instead of printk Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52692653.1060508@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.