From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Date: Thu, 24 Oct 2013 15:57:53 +0000 Subject: Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver Message-Id: <52694354.6030603@ti.com> List-Id: References: <1381940896-9355-1-git-send-email-kishon@ti.com> <1381940896-9355-4-git-send-email-kishon@ti.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi, On Thursday 24 October 2013 09:12 PM, Sachin Kamat wrote: > Hi Olof, > > On 24 October 2013 20:00, Olof Johansson wrote: >> Hi Kishon, >> >> On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I wrote: >>> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c >>> index 32e5406..00b3a52 100644 >>> --- a/drivers/video/exynos/exynos_mipi_dsi.c >>> +++ b/drivers/video/exynos/exynos_mipi_dsi.c >>> @@ -156,8 +157,7 @@ static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power) >>> exynos_mipi_regulator_enable(dsim); >>> >>> /* enable MIPI-DSI PHY. */ >>> - if (dsim->pd->phy_enable) >>> - dsim->pd->phy_enable(pdev, true); >>> + phy_power_on(dsim->phy); >>> >>> clk_enable(dsim->clock); >>> >> >> This introduces the below with exynos_defconfig: >> >> ../../drivers/video/exynos/exynos_mipi_dsi.c: In function >> 'exynos_mipi_dsi_blank_mode': >> ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused >> variable 'pdev' [-Wunused-variable] >> struct platform_device *pdev = to_platform_device(dsim->dev); >> > > I have already submitted a patch to fix this [1] > > [1] http://marc.info/?l=linux-fbdev&m8233359617936&w=2 Sorry, missed that :-( Thanks Kishon > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver Date: Thu, 24 Oct 2013 21:27:08 +0530 Message-ID: <52694354.6030603@ti.com> References: <1381940896-9355-1-git-send-email-kishon@ti.com> <1381940896-9355-4-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sachin Kamat Cc: "linux-fbdev@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Greg Kroah-Hartman , Olof Johansson , "linux-arm-kernel@lists.infradead.org" , Linux Media Mailing List List-Id: linux-samsung-soc@vger.kernel.org Hi, On Thursday 24 October 2013 09:12 PM, Sachin Kamat wrote: > Hi Olof, > > On 24 October 2013 20:00, Olof Johansson wrote: >> Hi Kishon, >> >> On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I wrote: >>> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c >>> index 32e5406..00b3a52 100644 >>> --- a/drivers/video/exynos/exynos_mipi_dsi.c >>> +++ b/drivers/video/exynos/exynos_mipi_dsi.c >>> @@ -156,8 +157,7 @@ static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power) >>> exynos_mipi_regulator_enable(dsim); >>> >>> /* enable MIPI-DSI PHY. */ >>> - if (dsim->pd->phy_enable) >>> - dsim->pd->phy_enable(pdev, true); >>> + phy_power_on(dsim->phy); >>> >>> clk_enable(dsim->clock); >>> >> >> This introduces the below with exynos_defconfig: >> >> ../../drivers/video/exynos/exynos_mipi_dsi.c: In function >> 'exynos_mipi_dsi_blank_mode': >> ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused >> variable 'pdev' [-Wunused-variable] >> struct platform_device *pdev = to_platform_device(dsim->dev); >> > > I have already submitted a patch to fix this [1] > > [1] http://marc.info/?l=linux-fbdev&m=138233359617936&w=2 Sorry, missed that :-( Thanks Kishon > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Thu, 24 Oct 2013 21:27:08 +0530 Subject: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver In-Reply-To: References: <1381940896-9355-1-git-send-email-kishon@ti.com> <1381940896-9355-4-git-send-email-kishon@ti.com> Message-ID: <52694354.6030603@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thursday 24 October 2013 09:12 PM, Sachin Kamat wrote: > Hi Olof, > > On 24 October 2013 20:00, Olof Johansson wrote: >> Hi Kishon, >> >> On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I wrote: >>> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c >>> index 32e5406..00b3a52 100644 >>> --- a/drivers/video/exynos/exynos_mipi_dsi.c >>> +++ b/drivers/video/exynos/exynos_mipi_dsi.c >>> @@ -156,8 +157,7 @@ static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power) >>> exynos_mipi_regulator_enable(dsim); >>> >>> /* enable MIPI-DSI PHY. */ >>> - if (dsim->pd->phy_enable) >>> - dsim->pd->phy_enable(pdev, true); >>> + phy_power_on(dsim->phy); >>> >>> clk_enable(dsim->clock); >>> >> >> This introduces the below with exynos_defconfig: >> >> ../../drivers/video/exynos/exynos_mipi_dsi.c: In function >> 'exynos_mipi_dsi_blank_mode': >> ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused >> variable 'pdev' [-Wunused-variable] >> struct platform_device *pdev = to_platform_device(dsim->dev); >> > > I have already submitted a patch to fix this [1] > > [1] http://marc.info/?l=linux-fbdev&m=138233359617936&w=2 Sorry, missed that :-( Thanks Kishon > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:41327 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756334Ab3JXP5h (ORCPT ); Thu, 24 Oct 2013 11:57:37 -0400 Message-ID: <52694354.6030603@ti.com> Date: Thu, 24 Oct 2013 21:27:08 +0530 From: Kishon Vijay Abraham I MIME-Version: 1.0 To: Sachin Kamat CC: Olof Johansson , Greg Kroah-Hartman , Linux Media Mailing List , "linux-arm-kernel@lists.infradead.org" , "linux-fbdev@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" Subject: Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver References: <1381940896-9355-1-git-send-email-kishon@ti.com> <1381940896-9355-4-git-send-email-kishon@ti.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi, On Thursday 24 October 2013 09:12 PM, Sachin Kamat wrote: > Hi Olof, > > On 24 October 2013 20:00, Olof Johansson wrote: >> Hi Kishon, >> >> On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I wrote: >>> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c >>> index 32e5406..00b3a52 100644 >>> --- a/drivers/video/exynos/exynos_mipi_dsi.c >>> +++ b/drivers/video/exynos/exynos_mipi_dsi.c >>> @@ -156,8 +157,7 @@ static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power) >>> exynos_mipi_regulator_enable(dsim); >>> >>> /* enable MIPI-DSI PHY. */ >>> - if (dsim->pd->phy_enable) >>> - dsim->pd->phy_enable(pdev, true); >>> + phy_power_on(dsim->phy); >>> >>> clk_enable(dsim->clock); >>> >> >> This introduces the below with exynos_defconfig: >> >> ../../drivers/video/exynos/exynos_mipi_dsi.c: In function >> 'exynos_mipi_dsi_blank_mode': >> ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused >> variable 'pdev' [-Wunused-variable] >> struct platform_device *pdev = to_platform_device(dsim->dev); >> > > I have already submitted a patch to fix this [1] > > [1] http://marc.info/?l=linux-fbdev&m=138233359617936&w=2 Sorry, missed that :-( Thanks Kishon > >