Re: [PATCH 1/3] memcg, kmem: Use is_root_cache instead of hard code

[Pekka Enberg <penberg@iki.fi>]

On 10/23/2013 02:31 PM, Qiang Huang wrote:
> Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
> ---
>   mm/memcontrol.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index b73988a..15ad0e3 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -57,6 +57,7 @@
>   #include <net/sock.h>
>   #include <net/ip.h>
>   #include <net/tcp_memcontrol.h>
> +#include "slab.h"
>   
>   #include <asm/uaccess.h>
>   
> @@ -3064,7 +3065,7 @@ int memcg_update_cache_size(struct kmem_cache *s, int num_groups)
>   {
>   	struct memcg_cache_params *cur_params = s->memcg_params;
>   
> -	VM_BUG_ON(s->memcg_params && !s->memcg_params->is_root_cache);
> +	VM_BUG_ON(!is_root_cache(s));
>   
>   	if (num_groups > memcg_limited_groups_array_size) {
>   		int i;

Reviewed-by: Pekka Enberg <penberg@kernel.org>

Andrew, I think your tree is the right place for these patches.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>