All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] common/env: Point default envirenoment for GD
Date: Thu, 24 Oct 2013 11:02:39 -0700	[thread overview]
Message-ID: <526960BF.5000605@freescale.com> (raw)
In-Reply-To: <1380616056-11196-1-git-send-email-prabhakar@freescale.com>

On 10/01/2013 01:27 AM, Prabhakar Kushwaha wrote:
> GD(Global Data) structure has pointer to envirenoment variable array.
> but, it is not being assigned for SPL framwork.
> 
> So update GD pointer with env variable array.
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
>  Based upon  git://git.denx.de/u-boot-mpc85xx.git branch next
> 
>  common/env_common.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/common/env_common.c b/common/env_common.c
> index 1ac3377..84843e1 100644
> --- a/common/env_common.c
> +++ b/common/env_common.c
> @@ -162,6 +162,9 @@ int env_import(const char *buf, int check)
>  	if (himport_r(&env_htab, (char *)ep->data, ENV_SIZE, '\0', 0,
>  			0, NULL)) {
>  		gd->flags |= GD_FLG_ENV_READY;
> +#ifdef CONFIG_SPL_BUILD
> +		gd->env_addr = ep->data;
> +#endif


You are assigning a pointer to a interger. This introduces compiling warning

env_common.c:166:16: warning: assignment makes integer from pointer
without a cast [enabled by default]

Please fix.

York

      reply	other threads:[~2013-10-24 18:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01  8:27 [U-Boot] [PATCH 3/6] common/env: Point default envirenoment for GD Prabhakar Kushwaha
2013-10-24 18:02 ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526960BF.5000605@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.