From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41129)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VZSlP-00059b-HN
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 17:48:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VZSlH-0006i6-59
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 17:48:19 -0400
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:34563)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VZSlG-0006hd-Up
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 17:48:11 -0400
Received: by mail-wg0-f42.google.com with SMTP id n12so186499wgh.5
	for <qemu-devel@nongnu.org>; Thu, 24 Oct 2013 14:48:09 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5269958A.50400@redhat.com>
Date: Thu, 24 Oct 2013 22:47:54 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20131023073949.GA4527@bom.nom.co> <52679025.3000106@redhat.com>
	<526830E6.6070904@weilnetz.de> <5268F8B4.7030105@redhat.com>
	<52694CC1.6040301@weilnetz.de>
In-Reply-To: <52694CC1.6040301@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] qemu 1.6.1
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: "Michael W. Bombardieri" <mb@ii.net>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Il 24/10/2013 17:37, Stefan Weil ha scritto:
> Yes, that works, too. It also fixes the problem with the assertion
> (tested with Wine).
> 
> No, we cannot remove from_, because the same interface is also used
> for Linux and other hosts which don't have a 'current' variable.
> Or we would have to call qemu_coroutine_self() to get the current
> coroutine.

Yes, I was thinking of using qemu_coroutine_self().

By the way, can you post the two assembly language outputs for just

-     CoroutineWin32 *from = DO_UPCAST(CoroutineWin32, base, from_);
+     CoroutineWin32 *from = DO_UPCAST(CoroutineWin32, base, current);

which AIUI works and is enough to fix the bug?

Paolo