From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZbkT-0006Vl-2n for qemu-devel@nongnu.org; Fri, 25 Oct 2013 03:24:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZbkJ-0002wg-52 for qemu-devel@nongnu.org; Fri, 25 Oct 2013 03:23:57 -0400 Received: from mail-we0-x231.google.com ([2a00:1450:400c:c03::231]:42497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZbkI-0002wJ-Tf for qemu-devel@nongnu.org; Fri, 25 Oct 2013 03:23:47 -0400 Received: by mail-we0-f177.google.com with SMTP id x55so3363516wes.36 for ; Fri, 25 Oct 2013 00:23:46 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <526A1C7E.8080506@redhat.com> Date: Fri, 25 Oct 2013 08:23:42 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1382412341-1173-1-git-send-email-lilei@linux.vnet.ibm.com> <1382412341-1173-10-git-send-email-lilei@linux.vnet.ibm.com> <526929A9.9030103@redhat.com> <5269F5B9.4020700@linux.vnet.ibm.com> In-Reply-To: <5269F5B9.4020700@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/17] migration-local: override before_ram_iterate to send pipefd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, mdroth@linux.vnet.ibm.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com Il 25/10/2013 05:38, Lei Li ha scritto: > > Just want to confirm, normally, should I take these 'otherwise looks > good/ok' > as a 'Reviewed-by' from you If the other comment is fixed in the update > version? Depends on how much the patch changes... right now I'm still expecting some changes so I didn't really look much at the patch and didn't test it. I prefer to take a more complete look at v3 before giving a "formal" Reviewed-by. Paolo