From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: alsa-devel@alsa-project.org, Wolfram Sang <wsa@the-dreams.de>,
linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
linux-i2c@vger.kernel.org
Subject: Re: [RFC 1/2] i2c: Use stable dev_name for ACPI enumerated I2C slaves
Date: Fri, 25 Oct 2013 16:30:23 +0300 [thread overview]
Message-ID: <526A726F.1030407@linux.intel.com> (raw)
In-Reply-To: <98785510.yWYAtabkbj@vostro.rjw.lan>
On 10/25/2013 04:18 PM, Rafael J. Wysocki wrote:
> On Friday, October 25, 2013 03:55:29 PM Jarkko Nikula wrote:
>>
>> Well, acpi_bus_get_device() is not available for non-ACPI builds and at
>> least the gcc I used for test build didn't optimize that block away.
> Well, it should. ACPI_HANDLE() translates to (NULL) if CONFIG_ACPI
> is not defined and that causes the check to become "if (NULL)" which
> should always be dropped by the compiler.
>
My very vague memory says the same. I don't know is this gcc version or
flag dependent behavior. I got the build error from both i386 build
using gcc 4.8.1 and arm build by using make ARCH=arm omap2plus_defconfig
and gcc-4.7-arm-linux-gnueabi 4.7.2-4.
> Does providing a stub acpi_bus_get_device() for !CONFIG_ACPI actually help?
>
>
Hmm, not only. Referencing to dev field in struct acpi_device by
dev_name(&adev->dev) here will fail too.
--
Jarkko
next prev parent reply other threads:[~2013-10-25 13:30 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 12:18 [RFC 0/2] I2C and SPI dev_name change for ACPI enumerated slaves Jarkko Nikula
[not found] ` <1382703540-3769-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-10-25 12:18 ` [RFC 1/2] i2c: Use stable dev_name for ACPI enumerated I2C slaves Jarkko Nikula
2013-10-25 12:52 ` Rafael J. Wysocki
[not found] ` <6032482.JJ4PNSSnIp-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-10-25 12:55 ` Jarkko Nikula
[not found] ` <526A6A41.6020909-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-10-25 13:18 ` Rafael J. Wysocki
2013-10-25 13:30 ` Jarkko Nikula [this message]
[not found] ` <526A726F.1030407-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-10-25 14:08 ` Rafael J. Wysocki
[not found] ` <2889412.bEKBLJtgSW-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-10-28 13:15 ` Jarkko Nikula
2013-10-28 16:10 ` Mark Brown
[not found] ` <526E636D.3070005-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-11-01 0:08 ` Rafael J. Wysocki
[not found] ` <1433914.mn8USodCgb-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-11-01 0:26 ` Rafael J. Wysocki
2013-10-25 12:19 ` [RFC 2/2] spi: Use stable dev_name for ACPI enumerated SPI slaves Jarkko Nikula
2013-10-25 12:59 ` Mark Brown
2013-10-25 14:09 ` Rafael J. Wysocki
2013-11-01 12:35 ` [PATCHv2 0/3] I2C and SPI dev_name change for ACPI enumerated slaves Jarkko Nikula
2013-11-01 12:35 ` [PATCHv2 2/3] i2c: Use stable dev_name for ACPI enumerated I2C slaves Jarkko Nikula
[not found] ` <1383309356-25430-3-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-11-02 0:15 ` Wolfram Sang
[not found] ` <1383309356-25430-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-11-01 12:35 ` [PATCHv2 1/3] ACPI: Expose struct acpi_device and acpi_bus_get_device() to non-ACPI builds Jarkko Nikula
2013-11-02 22:18 ` Rafael J. Wysocki
[not found] ` <3858838.4tAO673dDi-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-11-04 1:00 ` Rafael J. Wysocki
2013-11-04 21:15 ` Jarkko Nikula
2013-11-07 13:34 ` Rafael J. Wysocki
2013-11-01 12:35 ` [PATCHv2 3/3] spi: Use stable dev_name for ACPI enumerated SPI slaves Jarkko Nikula
[not found] ` <1383309356-25430-4-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-11-01 18:03 ` Mark Brown
2013-11-01 13:18 ` [PATCHv2 0/3] I2C and SPI dev_name change for ACPI enumerated slaves Rafael J. Wysocki
[not found] ` <1601125.4tFOPicoTX-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-11-01 13:20 ` Wolfram Sang
2013-11-01 13:44 ` Jarkko Nikula
2013-11-01 22:58 ` Rafael J. Wysocki
[not found] ` <3989164.GAoLSa6qzM-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-11-02 0:13 ` Wolfram Sang
2013-11-14 9:00 ` [PATCHv3 " Jarkko Nikula
[not found] ` <1384419661-28293-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-11-14 9:00 ` [PATCHv3 1/3] ACPI: Provide struct acpi_device stub for !CONFIG_ACPI builds Jarkko Nikula
2013-11-14 10:03 ` [alsa-devel] " Takashi Iwai
2013-11-14 11:14 ` Jarkko Nikula
2013-11-14 9:01 ` [PATCHv3 2/3] i2c: Use stable dev_name for ACPI enumerated I2C slaves Jarkko Nikula
2013-11-14 9:01 ` [PATCHv3 3/3] spi: Use stable dev_name for ACPI enumerated SPI slaves Jarkko Nikula
[not found] ` <1384419661-28293-4-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-11-14 10:10 ` Mark Brown
2013-11-14 12:03 ` [PATCHv4 0/3] I2C and SPI dev_name change for ACPI enumerated slaves Jarkko Nikula
[not found] ` <1384430633-23426-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-11-14 12:03 ` [PATCHv4 1/3] ACPI: Provide acpi_dev_name accessor for struct acpi_device device name Jarkko Nikula
2013-11-14 12:03 ` [PATCHv4 2/3] i2c: Use stable dev_name for ACPI enumerated I2C slaves Jarkko Nikula
[not found] ` <1384430633-23426-3-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-11-14 17:22 ` Wolfram Sang
2013-11-14 12:03 ` [PATCHv4 3/3] spi: Use stable dev_name for ACPI enumerated SPI slaves Jarkko Nikula
2013-11-16 1:30 ` [PATCHv4 0/3] I2C and SPI dev_name change for ACPI enumerated slaves Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526A726F.1030407@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.