From: Andrew Bradford <andrew@bradfordembedded.com>
To: linux-ext4@vger.kernel.org
Subject: e2fsprogs: Why __uint64_t in unix_discard() in lib/ext2fs/unix_io.c?
Date: Fri, 25 Oct 2013 09:54:36 -0400 [thread overview]
Message-ID: <526A781C.9090904@bradfordembedded.com> (raw)
In e2fsprogs commit e90a59ed434d6c5e38dd148aa4ba5b22b8f7eb24 the
unix_discard() function was implemented. Sorry, I was not subscribed
when that patch went to the list or I would have replied to it.
In unix_discard() in e2fsprogs lib/ext2fs/unix_io.c, starting at line
922 on the current git master branch HEAD, the __uint64_t type is used
for the range[] array which is used to perform an ioctl().
But, the BLKDISCARD ioctl() in the kernel uses uint64_t types to specify
the range.
Why is __uint64_t used in e2fsprogs's unix_discard() function? It's not
clear to me. This is the only use of __uint64_t in all of e2fsprogs.
Why wouldn't uint64_t work here?
Thanks,
Andrew
reply other threads:[~2013-10-25 13:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526A781C.9090904@bradfordembedded.com \
--to=andrew@bradfordembedded.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.