From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Va01w-0008Ud-MH for qemu-devel@nongnu.org; Sat, 26 Oct 2013 05:19:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Va01q-0004ml-N9 for qemu-devel@nongnu.org; Sat, 26 Oct 2013 05:19:36 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:35795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Va01q-0004m9-Fw for qemu-devel@nongnu.org; Sat, 26 Oct 2013 05:19:30 -0400 Message-ID: <526B8921.3060605@msgid.tls.msk.ru> Date: Sat, 26 Oct 2013 13:19:29 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <20131026090745.14894.51156.reportbug@localhost> In-Reply-To: <20131026090745.14894.51156.reportbug@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Bug#727756: qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Michael_B=FCsch?= , 727756@bugs.debian.org Cc: qemu-devel 26.10.2013 13:07, Michael B=FCsch wrote: > Package: qemu > Version: 1.6.0+dfsg-2 > Severity: normal > Tags: patch > > The smb.conf automatically generated by qemu's -smb option fails on cur= rent samba, > because smbd rejects the security=3Dshare option with the following war= ning: > >> WARNING: Ignoring invalid value 'share' for parameter 'security' > > Which makes it fall back to security=3Duser without guest login. > This results in being unable to login to the samba server from the gues= t OS. > > The attached patch fixes this by selecting 'user' explicitly and mappin= g > unknown users to guest logins. Index: qemu-1.6.0+dfsg/net/slirp.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- qemu-1.6.0+dfsg.orig/net/slirp.c +++ qemu-1.6.0+dfsg/net/slirp.c @@ -529,7 +529,8 @@ static int slirp_smb(SlirpState* s, cons "state directory=3D%s\n" "log file=3D%s/log.smbd\n" "smb passwd file=3D%s/smbpasswd\n" - "security =3D share\n" + "security =3D user\n" + "map to guest =3D Bad User\n" "[qemu]\n" "path=3D%s\n" "read only=3Dno\n" Thank you for the report and the patch Michael. Are you sure the result is equivalent? I mean, it *looks* like okay, because [qemu] share defini= tion - which looks like this: [qemu] path=3D%s read only=3Dno guest ok=3Dyes force user=3D%s explicitly says that guest is okay, and forces user to the right one. And it should work the same with other versions of samba too. But samba collected so many semi-conflicting options with years, so I'm not sure anymore. Also, which users are "bad" -- will it be possible for our user to "clash" with some built-in/known user? Cc'ing qemu-devel@ because this needs to be resolved upstream too. Thank you again, /mjt