From: Max Reitz <mreitz@redhat.com>
To: Thibaut LAURENT <thibaut.laurent@gmail.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Fix COR by disabling BDRV_O_COPY_ON_READ before opening the backing_file.
Date: Sat, 26 Oct 2013 15:31:12 +0200 [thread overview]
Message-ID: <526BC420.80907@redhat.com> (raw)
In-Reply-To: <1382660107-26518-1-git-send-email-thibaut.laurent@gmail.com>
Am 25.10.2013 02:15, schrieb Thibaut LAURENT:
> Since commit 0ebd24e0a203cf2852c310b59fbe050190dc6c8c,
> bdrv_open_common will throw an error when trying to open a file
> read-only with the BDRV_O_COPY_ON_READ flag set.
> Although BDRV_O_RDWR is unset for the backing files,
> BDRV_O_COPY_ON_READ is still passed on if copy-on-read was requested
> for the drive. Let's unset this flag too before opening the backing
> file, or bdrv_open_common will fail.
>
> Signed-off-by: Thibaut LAURENT <thibaut.laurent@gmail.com>
> ---
> block.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2013-10-26 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 0:15 [Qemu-devel] [PATCH] Fix COR by disabling BDRV_O_COPY_ON_READ before opening the backing_file Thibaut LAURENT
2013-10-26 13:31 ` Max Reitz [this message]
2013-10-29 11:56 ` Kevin Wolf
2013-10-28 15:08 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526BC420.80907@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thibaut.laurent@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.