Re: BUGS: btrfs multi-device support fixes

[Gene Czarcinski <gczarcinski@gmail.com>]

On 10/27/2013 02:54 AM, Andrey Borzenkov wrote:
> В Sat, 26 Oct 2013 16:16:19 -0400
> Gene Czarcinski <gczarcinski@gmail.com> пишет:
>
>> On 10/26/2013 12:27 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>> Rejected, similar patches is in trunk since some time.
>> Thanks.  I was not aware that the problem had been addressed.  Can you
>> point me where to look to see what has been addressed?
>>
> This is commit 588744d0dc655177d5883bdcb8f72ff5160109ed.
And that sure looks like something I would expect to see from a git 
repository!

Look, I am not stupid but I sure am confused!  The grub2 website 
(http://www.gnu.org/software/grub/) says that all grub2 development done 
through bazaar repository and that you get a copy of the latest grub2 
source with: |
   bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub|
Well, I tried doing that and all I get is an error saying: "bzr: ERROR: 
Not a branch:"

Now fedora has a local git repository for grub2 located here: 
git://pkgs.fedoraproject.org/grub2.git and when I look at what is there 
I see that the updates (when they come in) appear to be in git format.

On other little thing.  I I sent this current message there were TWO bug 
fixes (TWO patch files).  I well believe that the first one was already 
in trunk since I had originally reported that problem in January 2013.  
The reason I reported it again is because it had not been pick up by fedora.

However, there is that second bug fix which I only recently found and 
fixed.  This problem occurs when you have /boot on BTRFS either as a 
separate subvolume or simply as directory under the root subvolume. In 
10_linux, when grub2-probe is call for hint, it returns multi-device 
hints separated by "\n" which completely screws things up.  The patch is:
diff --git a/util/grub-probe.c b/util/grub-probe.c
index a46f0b1..dd5de00 100644
--- a/util/grub-probe.c
+++ b/util/grub-probe.c
@@ -543,7 +543,7 @@ probe (const char *path, char **device_names, char 
delim)
            print_full_name (map, dev);
            printf ("' ");
          }
-      printf ("\n");
+      printf (" "); /* new-line causes problems for multi-device btrfs 
volumes */

        grub_device_close (dev);
        continue;
-- 
>
>> Gene
>>> On 26.10.2013 17:36, Gene Czarcinski wrote:
>>>> There are two patches needed in grub2 to support multi-device btrfs
>>>> volumes.
>>>>
>>>> This first patch (previously submitted) involves the parameters passed
>>>> to grub2-probe.  If not correctly passed, grub2-probe issues an error
>>>> message.  The related problem report is:
>>>>     https://bugzilla.redhat.com/show_bug.cgi?id=890955
>>>>
>>>> The second problem involves having a multi-device btrfs volume with
>>>> /boot being on the btrfs volume either as part of the root subvolume or
>>>> as a separate subvolume.  The result is an error messare at boot time:
>>>>       error: no such device: root.
>>>>       hit any key to continue
>>>>
>>>> The solution is to modify grub-probe.c so that " " is issued rather than
>>>> "\n" for a hint.   The related problem report is:
>>>>     https://bugzilla.redhat.com/show_bug.cgi?id=1023161
>>>>
>>>> To minimize problems, the two patches have been attached rather than
>>>> provided inline.
>>>>
>>>> Peter, I cc'ed you so you would be aware of these bug reports.  It would
>>>> be nice if this was applied to both Fedora 20 and 19.
>>>>
>>>> Gene
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Grub-devel mailing list
>>>> Grub-devel@gnu.org
>>>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>