From: Charlie Shepherd <charlie@ctshepherd.com>
To: Gabriel Kerneis <gabriel@kerneis.info>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
stefanha@gmail.com
Subject: Re: [Qemu-devel] [PATCH v3 0/2] Documentation for coroutine annotations
Date: Sun, 27 Oct 2013 21:02:12 +0000 [thread overview]
Message-ID: <526D7F54.3020203@ctshepherd.com> (raw)
In-Reply-To: <20131027203713.GA6944@kerneis.info>
On 27/10/2013 20:37, Gabriel Kerneis wrote:
> On Sun, Oct 27, 2013 at 04:23:54PM +0100, Charlie Shepherd wrote:
>> These patches were the first two from my GSoC series and were reasonably
>> straight-forward and well accepted. Gabriel and I are hoping the patches from
>> GSoC can be merged before I start my job in December, so I'm starting by sending
>> the simple parts of the overall patchset, when they are merged then I will redo
>> the later parts in several smaller and more manageable patchsets.
> The patches look good, I just reviewed them again. They cannot be applied
> because you forgot --signoff.
>
> Also, I think it would be more consistent if you added the following patches in
> the same series:
> - add blocking_fn (I sent it to qemu-devel some time ago),
> - protect coroutine_fn and blocking_fn definition with #ifndef (to allow
> redefining them easily on the command line with extra cflags).
>
> Could you resend the series with these suggestions?
Good points, thanks, resent with your suggested changes.
Charlie
prev parent reply other threads:[~2013-10-27 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 15:23 [Qemu-devel] [PATCH v3 0/2] Documentation for coroutine annotations Charlie Shepherd
2013-10-27 15:23 ` [Qemu-devel] [PATCH v3 1/2] Add an explanation of when a function should be marked coroutine_fn Charlie Shepherd
2013-10-27 15:23 ` [Qemu-devel] [PATCH v3 2/2] Rename qemu_coroutine_self to qemu_coroutine_self_int and add an annotated wrapper Charlie Shepherd
2013-10-27 20:37 ` [Qemu-devel] [PATCH v3 0/2] Documentation for coroutine annotations Gabriel Kerneis
2013-10-27 21:02 ` Charlie Shepherd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526D7F54.3020203@ctshepherd.com \
--to=charlie@ctshepherd.com \
--cc=gabriel@kerneis.info \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.