From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaXTc-0000eQ-Dt for qemu-devel@nongnu.org; Sun, 27 Oct 2013 17:02:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VaXTU-0007zt-Us for qemu-devel@nongnu.org; Sun, 27 Oct 2013 17:02:24 -0400 Received: from mail6.webfaction.com ([74.55.86.74]:33912 helo=smtp.webfaction.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaXTU-0007zc-Q4 for qemu-devel@nongnu.org; Sun, 27 Oct 2013 17:02:16 -0400 Message-ID: <526D7F54.3020203@ctshepherd.com> Date: Sun, 27 Oct 2013 21:02:12 +0000 From: Charlie Shepherd MIME-Version: 1.0 References: <1382887436-17306-1-git-send-email-charlie@ctshepherd.com> <20131027203713.GA6944@kerneis.info> In-Reply-To: <20131027203713.GA6944@kerneis.info> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/2] Documentation for coroutine annotations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gabriel Kerneis Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com On 27/10/2013 20:37, Gabriel Kerneis wrote: > On Sun, Oct 27, 2013 at 04:23:54PM +0100, Charlie Shepherd wrote: >> These patches were the first two from my GSoC series and were reasonably >> straight-forward and well accepted. Gabriel and I are hoping the patches from >> GSoC can be merged before I start my job in December, so I'm starting by sending >> the simple parts of the overall patchset, when they are merged then I will redo >> the later parts in several smaller and more manageable patchsets. > The patches look good, I just reviewed them again. They cannot be applied > because you forgot --signoff. > > Also, I think it would be more consistent if you added the following patches in > the same series: > - add blocking_fn (I sent it to qemu-devel some time ago), > - protect coroutine_fn and blocking_fn definition with #ifndef (to allow > redefining them easily on the command line with extra cflags). > > Could you resend the series with these suggestions? Good points, thanks, resent with your suggested changes. Charlie