All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS
Date: Mon, 28 Oct 2013 00:16:35 +0100	[thread overview]
Message-ID: <526D9ED3.4000401@openwide.fr> (raw)


Ptrace support detection is ignored when CFLAGS is set by buildroot.

Use override in Makefile to add -DWARN_NO_PTRACE and -DNO_PTRACE in CFLAGS
if ptrace is not available.

Fixes:
http://autobuild.buildroot.net/results/60e/60ed317d52d93ba2c087aa6ff4f422d760806d89//

Signed-off-by: Romain <romain.naour@openwide.fr>
---
  .../trace-cmd-0002-Makefile-overwrite-CFLAGS.patch | 33 
++++++++++++++++++++++
  1 file changed, 33 insertions(+)
  create mode 100644 
package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch

diff --git 
a/package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch 
b/package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
new file mode 100644
index 0000000..f4afa53
--- /dev/null
+++ b/package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
@@ -0,0 +1,33 @@
+
+Ptrace support detection is ignored when CFLAGS is set in command 
arguments.
+
+Use override in Makefile to add -DWARN_NO_PTRACE and -DNO_PTRACE in CFLAGS
+if ptrace is not available.
+
+Signed-off-by: Romain <romain.naour@openwide.fr>
+---
+ Makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index 2f862ec..51b0df3 100644
+--- a/Makefile
++++ b/Makefile
+@@ -229,12 +229,12 @@ CFLAGS += -D_GNU_SOURCE
+ ifndef NO_PTRACE
+ ifneq ($(call try-cc,$(SOURCE_PTRACE),),y)
+     NO_PTRACE = 1
+-    CFLAGS += -DWARN_NO_PTRACE
++    override CFLAGS += -DWARN_NO_PTRACE
+ endif
+ endif
+
+ ifdef NO_PTRACE
+-CFLAGS += -DNO_PTRACE
++override CFLAGS += -DNO_PTRACE
+ endif
+
+ # Append required CFLAGS
+--
+1.8.1.4
+
-- 
1.8.1.4

             reply	other threads:[~2013-10-27 23:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-27 23:16 Romain Naour [this message]
2013-10-29 17:05 ` [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS Arnout Vandecappelle
2013-10-30  8:08   ` Thomas Petazzoni
2013-10-30 12:07     ` Arnout Vandecappelle
2013-10-30 21:45 ` Thomas Petazzoni
2013-10-31 17:26   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526D9ED3.4000401@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.