[U-Boot] [PATCH 1/2] esdhc: memset mmc struct before putting into use

From: Zhang Haijun <b42677@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] esdhc: memset mmc struct before putting into	use
Date: Mon, 28 Oct 2013 10:00:26 +0800	[thread overview]
Message-ID: <526DC53A.1050205@freescale.com> (raw)
In-Reply-To: <OFB7AF4A4B.DA4AB6FA-ON86257C0F.005991C1-86257C0F.005A78F3@rockwellcollins.com>

Thanks. Barnett

:-)
? 2013/10/26 0:28, Ryan Barnett ??:
> Haijun Zhang <Haijun.Zhang@freescale.com> wrote on 10/24/2013 08:54:42 PM:
>
>> struct mmc should be clear to all '0' after malloc to avoid
>> unexpect variable value.
>>
>> Like mmc->has_init = xxx.
>> In this case mmcinfo will believe the card had been initialized before
>> and skip the initialization.
>>
>> Test on P5040 and T4240,
>> Error Log:
>>
>> => mmcinfo
>> Device: FSL_SDHC
>> Manufacturer ID: 0
>> OEM: 0
>> Name: Tran Speed: 0
>> Rd Block Len: 0
>> MMC version 0.0
>> High Capacity: No
>> Capacity: 0 Bytes
>> Bus Width: 0-bit
>> =>
>>
>> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
>> Signed-off-by: Xie Shaohui-B21989 <B21989@freescale.com>
> Tested-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
>
> Verified that this patch fixes issues related to booting from eSDHC
> interface on the P2041RDB with U-Boot 2013.10.
>
>> ---
>>   drivers/mmc/fsl_esdhc.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
>> index a7170b4..d4c1eef 100644
>> --- a/drivers/mmc/fsl_esdhc.c
>> +++ b/drivers/mmc/fsl_esdhc.c
>> @@ -521,6 +521,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct
> fsl_esdhc_cfg *cfg)
>>      if (!mmc)
>>         return -ENOMEM;
>>
>> +   memset(mmc, 0, sizeof(struct mmc));
>>      sprintf(mmc->name, "FSL_SDHC");
>>      regs = (struct fsl_esdhc *)cfg->esdhc_base;
>>
>> -- 
>> 1.8.4
>>
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>

-- 
Thanks & Regards
Haijun.