From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gu Zheng Subject: Re: [PATCH V2] f2fs: check all ones or zeros bitmap with bitops for better mount performance Date: Mon, 28 Oct 2013 10:30:52 +0800 Message-ID: <526DCC5C.30808@cn.fujitsu.com> References: <000401ced092$28087a90$78196fb0$@samsung.com> <003501ced384$31fb7530$95f25f90$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VachR-00077Q-3f for linux-f2fs-devel@lists.sourceforge.net; Mon, 28 Oct 2013 02:37:01 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1VachP-0001tG-64 for linux-f2fs-devel@lists.sourceforge.net; Mon, 28 Oct 2013 02:37:01 +0000 In-Reply-To: <003501ced384$31fb7530$95f25f90$@samsung.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: =?UTF-8?B?7J207LC966eM?= Cc: =?UTF-8?B?J+iwreWnnSc=?= , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org T24gMTAvMjgvMjAxMyAxMDoxOSBBTSwg7J207LC966eMIHdyb3RlOgoKPiBUbyBjaGVjayB3aGV0 aGVyIGJpdG1hcCBhcmUgYWxsIHplcm9zIG9yIGFsbCBvbmVzLCBJIHRoaW5rIG1lbWNtcCBpcyBt b3JlIG5lYXQuCj4gQnV0IEkgZG9uJ3Qga25vdyBleGFjdGx5IHBlcmZvcm1hbmNlIGdhcCBiZXR3 ZWVuIG1lbWNtcCBhbmQgZmluZF9uZXh0X2JpdC4KCkFjY29yZGluZyB0byBteSB1bmRlcnN0YW5k aW5nLAptZW1jbXA6IG9uZSBieSBvbmUgc2VhcmNoLApmaW5kX25leHRfYml0OiBiaW5hcnkgc2Vh cmNoLgoKUmVnYXJkcywKR3UKCj4gCj4gCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiBG cm9tOiBDaGFvIFl1IFttYWlsdG86Y2hhbzIueXVAc2Ftc3VuZy5jb21dIAo+IFNlbnQ6IFRodXJz ZGF5LCBPY3RvYmVyIDI0LCAyMDEzIDU6MjEgUE0KPiBUbzogamFlZ2V1ay5raW1Ac2Ftc3VuZy5j b20KPiBDYzogbGludXgtZnNkZXZlbEB2Z2VyLmtlcm5lbC5vcmc7ICfosK3lp50nOyBsaW51eC1r ZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdl Lm5ldAo+IFN1YmplY3Q6IFtmMmZzLWRldl0gW1BBVENIIFYyXSBmMmZzOiBjaGVjayBhbGwgb25l cyBvciB6ZXJvcyBiaXRtYXAgd2l0aCBiaXRvcHMgZm9yIGJldHRlciBtb3VudCBwZXJmb3JtYW5j ZQo+IAo+IFByZXZpb3VzbHksIGNoZWNrX2Jsb2NrX2NvdW50IGNoZWNrIHZhbGlkX21hcCB3aXRo IGJpdCBkYXRhIHR5cGUgaW4gY29tbW9uIHNjZW5hcmlvIHRoYXQgc2l0IGhhcyBhbGwgb25lcyBv ciB6ZXJvcyBiaXRtYXAsIGl0IG1ha2VzIGxvdyBtb3VudCBwZXJmb3JtYW5jZS4KPiBTbyBsZXQn cyBjaGVjayB0aGUgc3BlY2lhbCBiaXRtYXAgd2l0aCBpbnRlZ2VyIGRhdGEgdHlwZSBpbnN0ZWFk IG9mIHRoZSBiaXQgb25lLgo+IAo+IHYyOgo+ICAgICB1c2UgZmluZF9uZXh0X2JpdF9sZS9maW5k X25leHRfemVyb19iaXRfbGUgZm9yIGJldHRlciBwZXJmb3JtYW5jZSBhbmQgcmVhZGFibGUgYXMg SmFlZ2V1ayBzdWdnZXN0ZWQuCj4gCj4gU3VnZ2VzdGVkLWJ5OiBKYWVnZXVrIEtpbSA8amFlZ2V1 ay5raW1Ac2Ftc3VuZy5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVGFuIFNodSA8c2h1LnRhbkBzYW1z dW5nLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBZdSBDaGFvIDxjaGFvMi55dUBzYW1zdW5nLmNvbT4K PiAtLS0KPiAgZnMvZjJmcy9zZWdtZW50LmggfCAgIDE3ICsrKysrKysrKysrKysrKysrCj4gIDEg ZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2ZzL2YyZnMv c2VnbWVudC5oIGIvZnMvZjJmcy9zZWdtZW50LmggaW5kZXggN2Y5NGQ3OC4uZDI1YjZhZiAxMDA2 NDQKPiAtLS0gYS9mcy9mMmZzL3NlZ21lbnQuaAo+ICsrKyBiL2ZzL2YyZnMvc2VnbWVudC5oCj4g QEAgLTU1Miw2ICs1NTIsMjMgQEAgc3RhdGljIGlubGluZSB2b2lkIGNoZWNrX2Jsb2NrX2NvdW50 KHN0cnVjdCBmMmZzX3NiX2luZm8gKnNiaSwKPiAgCS8qIGNoZWNrIGJvdW5kYXJ5IG9mIGEgZ2l2 ZW4gc2VnbWVudCBudW1iZXIgKi8KPiAgCUJVR19PTihzZWdubyA+IGVuZF9zZWdubyk7Cj4gIAo+ ICsJLyogY2hlY2sgYWxsIG9uZXMgb3IgemVyb3MgdmFsaWRfbWFwICovCj4gKwlpZiAoR0VUX1NJ VF9WQkxPQ0tTKHJhd19zaXQpID09IDApIHsKPiArCQlpbnQgcG9zID0gZmluZF9uZXh0X2JpdF9s ZSgmcmF3X3NpdC0+dmFsaWRfbWFwLAo+ICsJCQkJCXNiaS0+YmxvY2tzX3Blcl9zZWcsCj4gKwkJ CQkJMCk7Cj4gKwkJaWYgKHBvcyAhPSBzYmktPmJsb2Nrc19wZXJfc2VnKQo+ICsJCQlCVUcoKTsK PiArCQlyZXR1cm47Cj4gKwl9IGVsc2UgaWYgKEdFVF9TSVRfVkJMT0NLUyhyYXdfc2l0KSA9PSBz YmktPmJsb2Nrc19wZXJfc2VnKSB7Cj4gKwkJaW50IHBvcyA9IGZpbmRfbmV4dF96ZXJvX2JpdF9s ZSgmcmF3X3NpdC0+dmFsaWRfbWFwLAo+ICsJCQkJCXNiaS0+YmxvY2tzX3Blcl9zZWcsCj4gKwkJ CQkJMCk7Cj4gKwkJaWYgKHBvcyAhPSBzYmktPmJsb2Nrc19wZXJfc2VnKQo+ICsJCQlCVUcoKTsK PiArCQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICAJLyogY2hlY2sgYml0bWFwIHdpdGggdmFsaWQgYmxv Y2sgY291bnQgKi8KPiAgCWZvciAoaSA9IDA7IGkgPCBzYmktPmJsb2Nrc19wZXJfc2VnOyBpKysp Cj4gIAkJaWYgKGYyZnNfdGVzdF9iaXQoaSwgcmF3X3NpdC0+dmFsaWRfbWFwKSkKPiAtLQo+IDEu Ny45LjUKPiAKPiAKPiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiBPY3RvYmVyIFdlYmluYXJzOiBD b2RlIGZvciBQZXJmb3JtYW5jZQo+IEZyZWUgSW50ZWwgd2ViaW5hcnMgY2FuIGhlbHAgeW91IGFj Y2VsZXJhdGUgYXBwbGljYXRpb24gcGVyZm9ybWFuY2UuCj4gRXhwbG9yZSB0aXBzIGZvciBNUEks IE9wZW5NUCwgYWR2YW5jZWQgcHJvZmlsaW5nLCBhbmQgbW9yZS4gR2V0IHRoZSBtb3N0IGZyb20g Cj4gdGhlIGxhdGVzdCBJbnRlbCBwcm9jZXNzb3JzIGFuZCBjb3Byb2Nlc3NvcnMuIFNlZSBhYnN0 cmFjdHMgYW5kIHJlZ2lzdGVyID4KPiBodHRwOi8vcHViYWRzLmcuZG91YmxlY2xpY2submV0L2dh bXBhZC9jbGs/aWQ9NjAxMzU5OTEmaXU9LzQxNDAvb3N0Zy5jbGt0cmsKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LWYyZnMtZGV2ZWwgbWFp bGluZyBsaXN0Cj4gTGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKPiBodHRw czovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRldmVs Cj4gCj4gLS0KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAi dW5zdWJzY3JpYmUgbGludXgta2VybmVsIiBpbgo+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBt YWpvcmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDov L3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCj4gUGxlYXNlIHJlYWQgdGhlIEZB USBhdCAgaHR0cDovL3d3dy50dXgub3JnL2xrbWwvCj4gCgoKCi0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQpPY3RvYmVyIFdlYmluYXJzOiBDb2RlIGZvciBQZXJmb3JtYW5jZQpGcmVlIEludGVsIHdlYmlu YXJzIGNhbiBoZWxwIHlvdSBhY2NlbGVyYXRlIGFwcGxpY2F0aW9uIHBlcmZvcm1hbmNlLgpFeHBs b3JlIHRpcHMgZm9yIE1QSSwgT3Blbk1QLCBhZHZhbmNlZCBwcm9maWxpbmcsIGFuZCBtb3JlLiBH ZXQgdGhlIG1vc3QgZnJvbSAKdGhlIGxhdGVzdCBJbnRlbCBwcm9jZXNzb3JzIGFuZCBjb3Byb2Nl c3NvcnMuIFNlZSBhYnN0cmFjdHMgYW5kIHJlZ2lzdGVyID4KaHR0cDovL3B1YmFkcy5nLmRvdWJs ZWNsaWNrLm5ldC9nYW1wYWQvY2xrP2lkPTYwMTM1OTkxJml1PS80MTQwL29zdGcuY2xrdHJrCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMt ZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0 Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755459Ab3J1ChC (ORCPT ); Sun, 27 Oct 2013 22:37:02 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:45628 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754546Ab3J1Cg6 convert rfc822-to-8bit (ORCPT ); Sun, 27 Oct 2013 22:36:58 -0400 X-IronPort-AV: E=Sophos;i="4.93,582,1378828800"; d="scan'208";a="8873666" Message-ID: <526DCC5C.30808@cn.fujitsu.com> Date: Mon, 28 Oct 2013 10:30:52 +0800 From: Gu Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: =?UTF-8?B?7J207LC966eM?= CC: "'Chao Yu'" , jaegeuk.kim@samsung.com, linux-fsdevel@vger.kernel.org, =?UTF-8?B?J+iwreWnnSc=?= , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH V2] f2fs: check all ones or zeros bitmap with bitops for better mount performance References: <000401ced092$28087a90$78196fb0$@samsung.com> <003501ced384$31fb7530$95f25f90$@samsung.com> In-Reply-To: <003501ced384$31fb7530$95f25f90$@samsung.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/10/28 10:35:11, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/10/28 10:35:13 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/2013 10:19 AM, 이창만 wrote: > To check whether bitmap are all zeros or all ones, I think memcmp is more neat. > But I don't know exactly performance gap between memcmp and find_next_bit. According to my understanding, memcmp: one by one search, find_next_bit: binary search. Regards, Gu > > > -----Original Message----- > From: Chao Yu [mailto:chao2.yu@samsung.com] > Sent: Thursday, October 24, 2013 5:21 PM > To: jaegeuk.kim@samsung.com > Cc: linux-fsdevel@vger.kernel.org; '谭姝'; linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: [f2fs-dev] [PATCH V2] f2fs: check all ones or zeros bitmap with bitops for better mount performance > > Previously, check_block_count check valid_map with bit data type in common scenario that sit has all ones or zeros bitmap, it makes low mount performance. > So let's check the special bitmap with integer data type instead of the bit one. > > v2: > use find_next_bit_le/find_next_zero_bit_le for better performance and readable as Jaegeuk suggested. > > Suggested-by: Jaegeuk Kim > Signed-off-by: Tan Shu > Signed-off-by: Yu Chao > --- > fs/f2fs/segment.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index 7f94d78..d25b6af 100644 > --- a/fs/f2fs/segment.h > +++ b/fs/f2fs/segment.h > @@ -552,6 +552,23 @@ static inline void check_block_count(struct f2fs_sb_info *sbi, > /* check boundary of a given segment number */ > BUG_ON(segno > end_segno); > > + /* check all ones or zeros valid_map */ > + if (GET_SIT_VBLOCKS(raw_sit) == 0) { > + int pos = find_next_bit_le(&raw_sit->valid_map, > + sbi->blocks_per_seg, > + 0); > + if (pos != sbi->blocks_per_seg) > + BUG(); > + return; > + } else if (GET_SIT_VBLOCKS(raw_sit) == sbi->blocks_per_seg) { > + int pos = find_next_zero_bit_le(&raw_sit->valid_map, > + sbi->blocks_per_seg, > + 0); > + if (pos != sbi->blocks_per_seg) > + BUG(); > + return; > + } > + > /* check bitmap with valid block count */ > for (i = 0; i < sbi->blocks_per_seg; i++) > if (f2fs_test_bit(i, raw_sit->valid_map)) > -- > 1.7.9.5 > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >