All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/irq: Print direct vector mappings in the 'i' debug key
Date: Mon, 28 Oct 2013 10:11:00 +0000	[thread overview]
Message-ID: <526E3834.9060604@citrix.com> (raw)
In-Reply-To: <526E3DF802000078000FD29C@nat28.tlf.novell.com>

On 28/10/13 09:35, Jan Beulich wrote:
>>>> On 24.10.13 at 13:24, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> @@ -2285,6 +2285,14 @@ static void dump_irqs(unsigned char key)
>>          xfree(ssid);
>>      }
>>  
>> +    printk("Direct vector information:\n");
>> +    for ( i = 0; i < NR_VECTORS; ++i )
>> +        if ( direct_apic_vector[i] )
>> +        {
>> +            printk("   %#04x -> ", i);
>> +            print_function("%s()\n", (unsigned long)direct_apic_vector[i]);
> Did you build test this? I can't seem to find any print_function() in
> the staging tree...
>
> Jan
>

Sorry.  I developed this on my branch which includes the patch to drop
the +0/<len> (posted a while back).  I clearly forgotten to refresh the
patch when testing against staging.  (I really need to get out of the
habit of doing this).

I will get around to doing the %p modifiers in some amount of free time,
but print_symbol() was intended here.  v2 on its way.

~Andrew

  reply	other threads:[~2013-10-28 10:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 11:24 [PATCH] x86/irq: Print direct vector mappings in the 'i' debug key Andrew Cooper
2013-10-28  9:35 ` Jan Beulich
2013-10-28 10:11   ` Andrew Cooper [this message]
2013-10-28 10:28     ` [PATCH v2] " Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526E3834.9060604@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.