From: Pekka Enberg <penberg@iki.fi>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Hemant Kumar <hkshaw@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Oleg Nesterov <oleg@redhat.com>,
hegdevasant@linux.vnet.ibm.com, Ingo Molnar <mingo@redhat.com>,
anton@redhat.com, systemtap@sourceware.org,
Namhyung Kim <namhyung@kernel.org>,
aravinda@linux.vnet.ibm.com
Subject: Re: [PATCH v4 2/3] Support for perf to probe into SDT markers:
Date: Mon, 28 Oct 2013 19:48:22 +0200 [thread overview]
Message-ID: <526EA366.4020204@iki.fi> (raw)
In-Reply-To: <20131028173152.GB1040@linux.vnet.ibm.com>
On 10/28/13 7:31 PM, Srikar Dronamraju wrote:
>>> But what if a system has both 32 bit libc and 64 bit libc?
>>> Wont we could end up with 2 libc:setjmp?
>>> Should we give some more intelligence into perf to choose the 64 bit
>>> libc over 32 bit one?
>> You can just trace both of them by default, no?
>>
> There has to be a one to one association with the event name and its
> mapping. Every event name will finally map to a unique inode and an
> offset.
>
> One option would be for perf to look at these markers and have a
> different event name for similar markers in different executables.
I think we are talking past each other here.
Yes, I understand that you need an fully qualified name
for a SDT marker but there's absolutely no reason to force
feed that to the user of 'perf trace'.
For the 32-bit and 64-bit libc case, why cannot 'perf list'
by default print out something like:
$ perf list
libc:setjmp [SDT marker group]
and provide a '--fully-qualified' command line option that:
$ perf list --fully-qualified
libc:setjmp => libc32:setjmp, libc64:setjmp [SDT marker group]
libc32:setjmp => libc:setjmp@/lib/libc.so.6 [SDT marker]
libc64:setjmp => libc:setjmp@/lib64/libc.so.6 [SDT marker]
and then teach 'perf trace' to deal with SDT marker groups
where you trace two events, not one?
And again, there's no reason to treat system libraries like
libc the same way as some random binary in $HOME. You
can use the fully qualified name in 'perf list' for things
that are not in /lib or some perf-specific whitelist.
Pekka
next prev parent reply other threads:[~2013-10-28 17:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 5:04 [PATCH v4 0/3] perf support to SDT markers Hemant Kumar
2013-10-23 5:04 ` [PATCH v4 1/3] SDT markers listing by perf: Hemant Kumar
2013-10-23 5:05 ` [PATCH v4 2/3] Support for perf to probe into SDT markers: Hemant Kumar
2013-10-24 5:45 ` Masami Hiramatsu
2013-10-24 10:25 ` Hemant Kumar
2013-10-25 12:38 ` Pekka Enberg
2013-10-25 12:59 ` Srikar Dronamraju
2013-10-25 14:20 ` Pekka Enberg
2013-10-25 15:20 ` David Ahern
2013-10-28 8:48 ` Pekka Enberg
2013-10-28 16:59 ` David Ahern
2013-10-28 18:45 ` Pekka Enberg
2013-10-29 9:55 ` Hemant Kumar
2013-10-29 14:05 ` Pekka Enberg
2013-10-29 19:41 ` Hemant Kumar
2013-10-30 10:22 ` Masami Hiramatsu
2013-10-26 9:50 ` Ingo Molnar
2013-10-28 8:56 ` Pekka Enberg
2013-10-28 10:57 ` Masami Hiramatsu
2013-10-29 5:50 ` Namhyung Kim
2013-10-26 11:16 ` Frank Ch. Eigler
2013-10-28 8:40 ` Pekka Enberg
2013-10-28 10:34 ` Ingo Molnar
2013-10-30 10:05 ` Masami Hiramatsu
2013-10-30 11:51 ` Pekka Enberg
2013-10-31 9:59 ` Ingo Molnar
2013-10-31 10:54 ` Mark Wielaard
2013-10-31 10:57 ` Ingo Molnar
2013-10-31 13:12 ` Peter Zijlstra
2013-10-31 13:23 ` Mark Wielaard
2013-10-30 13:30 ` Hemant Kumar
2013-10-28 11:23 ` Masami Hiramatsu
2013-10-28 12:42 ` Pekka Enberg
2013-10-28 14:11 ` Srikar Dronamraju
2013-10-28 14:21 ` Pekka Enberg
2013-10-28 17:31 ` Srikar Dronamraju
2013-10-28 17:48 ` Pekka Enberg [this message]
2013-10-29 3:19 ` Masami Hiramatsu
2013-10-29 5:31 ` Namhyung Kim
2013-10-29 14:51 ` Mark Wielaard
2013-10-29 19:54 ` Pekka Enberg
2013-10-29 2:51 ` Masami Hiramatsu
2013-10-23 5:05 ` [PATCH v4 3/3] Documentation regarding perf/sdt Hemant Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526EA366.4020204@iki.fi \
--to=penberg@iki.fi \
--cc=anton@redhat.com \
--cc=aravinda@linux.vnet.ibm.com \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=hkshaw@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.